Skip to content

Ignore RuntimeError in AbstractConnection._close #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

chbndrhnns
Copy link

@chbndrhnns chbndrhnns commented May 21, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixes #3239 by ignoring a RuntimeError

@chbndrhnns chbndrhnns changed the title Fix ignored exception in AbstractConnection._close Ignore RuntimeError in AbstractConnection._close May 21, 2024
@chbndrhnns
Copy link
Author

@gerzse Could you help me proceed with this PR? It's my first one and I would like to know what needs to happen next from my side.

@chbndrhnns
Copy link
Author

@vladvildanov Hi there, my very small PR seems to have gotten no attention in the last 5 months and I wanted to ask if there is something I could do about it?

@chbndrhnns chbndrhnns closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception ignored in: <function AbstractConnection.__del__ at 0x107907240>
1 participant