Skip to content

Throw NotImplementedError for HELLO #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 6, 2022
Merged

Throw NotImplementedError for HELLO #1912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef7d5e3
unsupported hello
dvora-h Jan 30, 2022
ccdd586
add test and docstring
dvora-h Feb 3, 2022
c36fdd4
linters
dvora-h Feb 3, 2022
14fed96
fix docstring
dvora-h Feb 6, 2022
f3a71f7
Merge branch 'master' into unsupported-hello
dvora-h Feb 6, 2022
3934b1c
linters
dvora-h Feb 6, 2022
c1c5eec
linters
dvora-h Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions redis/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,6 +1087,15 @@ def wait(self, num_replicas, timeout, **kwargs):
"""
return self.execute_command("WAIT", num_replicas, timeout, **kwargs)

def hello(self):
"""
This function throws a NotImplementedError since it is intentionally
not supported.
"""
raise NotImplementedError(
"HELLO is intentionally not implemented in the client."
)

def failover(self):
"""
This function throws a NotImplementedError since it is intentionally
Expand Down
5 changes: 5 additions & 0 deletions tests/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,11 @@ def test_client_getredir(self, r):
assert isinstance(r.client_getredir(), int)
assert r.client_getredir() == -1

@skip_if_server_version_lt("6.0.0")
def test_hello_notI_implemented(self, r):
with pytest.raises(NotImplementedError):
r.hello()

def test_config_get(self, r):
data = r.config_get()
assert len(data.keys()) > 10
Expand Down