Skip to content

Add packaging to setup_requires, and use >= to play nice to setup.py (fixes #1625) #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

hartwork
Copy link
Contributor

@hartwork hartwork commented Dec 9, 2021

Fixes unfixed (but closed) issue #1625, more details at #1625 (comment) . Thanks! 🙏

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #1780 (80a7211) into master (bba31cd) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1780      +/-   ##
==========================================
+ Coverage   94.28%   94.29%   +0.01%     
==========================================
  Files          74       74              
  Lines       15696    15696              
==========================================
+ Hits        14799    14801       +2     
+ Misses        897      895       -2     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
tests/test_cluster.py 98.67% <0.00%> (ø)
tests/conftest.py 92.89% <0.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291baa9...80a7211. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Dec 9, 2021
@chayim
Copy link
Contributor

chayim commented Dec 9, 2021

Thank you for your contribution @hartwork. Admittedly we don't currently test for a pip install of the package (automatically), though I think we should. It would also help when updates (like this) are missed by me. Much thanks! Merging.

@chayim chayim changed the title setup.py: Add packaging to setup_requires, and use >= to play nice (fixes #1625) Add packaging to setup_requires, and use >= to play nice to setup.py (fixes #1625) Dec 9, 2021
@chayim chayim merged commit a58f423 into redis:master Dec 9, 2021
@hartwork hartwork deleted the issue-1625-fix-setup-py-requirements branch December 9, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants