Skip to content

Fix cluster ACL tests #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Fix cluster ACL tests #1774

merged 2 commits into from
Dec 8, 2021

Conversation

barshaul
Copy link
Contributor

@barshaul barshaul commented Dec 5, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • [X ] Does $ tox pass with this change (including linting)?
  • [ X] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [X ] Is the new or changed code fully tested?
  • [ X] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [X ] Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Added permissions to run INFO command so the cluster instance would be able to finish initialization

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2021

Codecov Report

Merging #1774 (6b67df4) into master (11b1463) will increase coverage by 13.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1774       +/-   ##
===========================================
+ Coverage   80.97%   94.29%   +13.31%     
===========================================
  Files          74       74               
  Lines       15062    15696      +634     
===========================================
+ Hits        12197    14801     +2604     
+ Misses       2865      895     -1970     
Impacted Files Coverage Δ
tests/test_cluster.py 98.79% <ø> (+83.97%) ⬆️
tests/test_commands.py 99.38% <ø> (+0.26%) ⬆️
tests/test_retry.py 100.00% <0.00%> (ø)
tests/test_pipeline.py 100.00% <0.00%> (ø)
tests/test_scripting.py 100.00% <0.00%> (ø)
tests/test_timeseries.py 100.00% <0.00%> (ø)
redis/commands/json/path.py 100.00% <0.00%> (ø)
tests/test_command_parser.py 100.00% <0.00%> (ø)
redis/commands/bf/__init__.py 100.00% <0.00%> (ø)
tests/test_connection_pool.py 100.00% <0.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b1463...6b67df4. Read the comment docs.

@barshaul barshaul marked this pull request as ready for review December 5, 2021 07:52
@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Dec 8, 2021
@chayim chayim changed the title Fixed cluster ACL tests Fix cluster ACL tests Dec 8, 2021
@chayim chayim merged commit 748c8d1 into redis:master Dec 8, 2021
@chayim chayim deleted the master_merged branch December 8, 2021 08:17
chayim pushed a commit to chayim/redis-py that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants