Skip to content

Added support for MONITOR in clusters #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 2, 2021
Merged

Conversation

barshaul
Copy link
Contributor

@barshaul barshaul commented Nov 29, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • [X ] Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [X ] Is the new or changed code fully tested?
  • [X ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [X ] Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Added support for MONITOR command to RedisCluster
closes #1758

@barshaul barshaul marked this pull request as ready for review November 29, 2021 10:25
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #1756 (43a5a8f) into master (12f45ee) will increase coverage by 3.37%.
The diff coverage is 93.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1756      +/-   ##
==========================================
+ Coverage   90.89%   94.26%   +3.37%     
==========================================
  Files          59       74      +15     
  Lines       14229    15669    +1440     
==========================================
+ Hits        12933    14771    +1838     
+ Misses       1296      898     -398     
Impacted Files Coverage Δ
redis/commands/core.py 90.05% <ø> (+6.05%) ⬆️
redis/commands/search/querystring.py 0.00% <0.00%> (ø)
redis/utils.py 83.87% <ø> (+6.45%) ⬆️
setup.py 0.00% <0.00%> (ø)
tests/test_cluster.py 98.78% <ø> (+0.32%) ⬆️
tests/test_commands.py 99.38% <ø> (+5.90%) ⬆️
redis/commands/sentinel.py 64.28% <23.07%> (ø)
redis/commands/search/document.py 87.50% <50.00%> (ø)
redis/commands/graph/exceptions.py 66.66% <66.66%> (ø)
redis/commands/search/result.py 97.22% <66.66%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db85ef...43a5a8f. Read the comment docs.

@barshaul barshaul changed the title Added support for ACL commands to RedisCluster Added support for ACL and MONITOR commands to RedisCluster Nov 29, 2021
@chayim chayim added 4.1.0 maintenance Maintenance (CI, Releases, etc) labels Nov 29, 2021
@chayim chayim self-requested a review November 29, 2021 17:50
@chayim
Copy link
Contributor

chayim commented Dec 2, 2021

@barshaul Something appears to be incorrect with your environment. Using this PR as an example there are 84 file changes - many of which are already in master. Can you please have a look at that? A good example is the first file - changes appear for the workflow - which is already in master, and should appear accordingly as a merge.

@chayim chayim self-requested a review December 2, 2021 17:47
@barshaul barshaul changed the title Added support for ACL and MONITOR commands to RedisCluster Added support for MONITOR command to RedisCluster; Fixed #1758 Dec 2, 2021
@chayim chayim changed the title Added support for MONITOR command to RedisCluster; Fixed #1758 Added support for MONITOR in clusters Dec 2, 2021
@chayim chayim merged commit 11b1463 into redis:master Dec 2, 2021
@chayim chayim deleted the master_merged branch December 2, 2021 20:59
@chayim chayim added feature New feature 4.1.0 and removed 4.1.0 maintenance Maintenance (CI, Releases, etc) labels Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@skip_if_redis_enterprise skips tests regardless to the 'enterprise' value
3 participants