Skip to content

Support RediSearch FT.PROFILE command #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 25, 2021
Merged

Conversation

AvitalFineRedis
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1687

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #1727 (aad03f0) into master (5604573) will decrease coverage by 2.97%.
The diff coverage is 86.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
- Coverage   92.21%   89.23%   -2.98%     
==========================================
  Files          53       53              
  Lines       11005    11137     +132     
==========================================
- Hits        10148     9938     -210     
- Misses        857     1199     +342     
Impacted Files Coverage Δ
redis/lock.py 100.00% <ø> (ø)
tests/test_monitor.py 74.50% <44.44%> (-25.50%) ⬇️
tests/test_commands.py 93.14% <70.96%> (-6.67%) ⬇️
tests/conftest.py 92.25% <75.00%> (-1.41%) ⬇️
redis/client.py 82.08% <80.00%> (-5.68%) ⬇️
redis/commands/helpers.py 92.00% <93.10%> (+0.69%) ⬆️
redis/commands/search/commands.py 87.88% <96.15%> (+0.71%) ⬆️
redis/commands/core.py 83.86% <100.00%> (-6.20%) ⬇️
redis/commands/redismodules.py 100.00% <100.00%> (+22.22%) ⬆️
redis/commands/search/__init__.py 81.81% <100.00%> (-0.54%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5604573...aad03f0. Read the comment docs.

@chayim chayim added the 4.1.0 label Nov 21, 2021
@chayim
Copy link
Contributor

chayim commented Nov 21, 2021

@AvitalFineRedis It looks like this radically reduces our code coverage. Can you take a look please? It seems inaccurate.

@chayim chayim added the feature New feature label Nov 23, 2021
@chayim chayim changed the title Support ft.profile Support RediSearch FT.PROFILE command Nov 25, 2021
@chayim chayim merged commit 393cd62 into redis:master Nov 25, 2021
@AvitalFineRedis AvitalFineRedis deleted the ft.profile branch December 6, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for FT.PROFILE
3 participants