Skip to content

Support for json multipath ($) #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 4, 2021
Merged

Support for json multipath ($) #1663

merged 10 commits into from
Nov 4, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Oct 31, 2021

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Adding support for JSON.NUMPOWBY command

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #1663 (70466b2) into master (75c5d59) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
+ Coverage   89.49%   89.75%   +0.26%     
==========================================
  Files          58       57       -1     
  Lines       10771    11072     +301     
==========================================
+ Hits         9639     9938     +299     
- Misses       1132     1134       +2     
Impacted Files Coverage Δ
redis/commands/helpers.py 70.00% <100.00%> (-7.78%) ⬇️
redis/commands/json/__init__.py 100.00% <100.00%> (ø)
redis/commands/json/commands.py 95.55% <100.00%> (ø)
redis/commands/json/decoders.py 100.00% <100.00%> (ø)
tests/conftest.py 96.35% <100.00%> (ø)
tests/test_json.py 100.00% <100.00%> (ø)
redis/commands/timeseries/info.py 91.42% <0.00%> (-2.86%) ⬇️
tests/test_search.py 98.61% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c5d59...70466b2. Read the comment docs.

@chayim chayim marked this pull request as ready for review November 3, 2021 12:11
@chayim chayim merged commit 8d3c615 into master Nov 4, 2021
@chayim chayim deleted the ck-json-multipath branch November 4, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants