Adds v5 new client subcommands #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itamar Haber <[email protected]>
Signed-off-by: Itamar Haber <[email protected]>
itamarhaber
changed the title
Signed-off-by: Itamar Haber <[email protected]>
andymccurdy
suggested changes
Nov 4, 2018
There was a problem hiding this comment.
I think the CLIENT UNBLOCK implementation could be improved to take a boolean error=False instead of a string. Then the implementation would simply append 'ERROR' to the command if error==True. From the docs, I see no reason why we ever need to pass 'TIMEOUT' as that's the default if no options are specified. Am I missing something?
|
@andymccurdy agreed - merging @RoeyPrat's PR to address that. |
Remove reason arg from client_unblock. Use boolean 'error' arg instead. xref: #1036 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically,
CLIENT IDandCLIENT UNBLOCK.