Skip to content

Wrong type annotation on fcall methods #3536

Closed
@alethiophile

Description

@alethiophile

The argument signature for the fcall methods reads:

self, function, numkeys: int, *keys_and_args: Optional[List]

Per PEP 484, the type annotation for an argument list should be the type of the expected elements, not List. This causes mypy to return spurious errors on code including the fcall method.

I believe this annotation should be *keys_and_args: Any.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions