Skip to content

resp3 parser async parser incorrectly parses maps #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kristjanvalur opened this issue Oct 5, 2023 · 1 comment · Fixed by #2982
Closed

resp3 parser async parser incorrectly parses maps #2981

kristjanvalur opened this issue Oct 5, 2023 · 1 comment · Fixed by #2982

Comments

@kristjanvalur
Copy link
Contributor

Issue discovered in pr #2947

the evaulation order of key:val in {key():val() for foo in bar} dict comprehension is undefined in Python. It mostly is left-right,
but some versions, notably recent 3.7 versions, don't behave that way. It is best to use explicit ordering when reading from a stream.

This had already been fixed for non-async parsing, but in pr #2947 caused some scheduling behaviour which triggered this to happen. A fix for async has been added there.

@kristjanvalur
Copy link
Contributor Author

I guess a standalone fix should be done as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant