Skip to content

support for BGREWRITEAOF ? #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twidi opened this issue Apr 1, 2010 · 1 comment
Closed

support for BGREWRITEAOF ? #26

twidi opened this issue Apr 1, 2010 · 1 comment

Comments

@twidi
Copy link
Contributor

twidi commented Apr 1, 2010

It seems redis-py has not support for the BGREWRITEAOF command.

Could it be implemented ?

Thanks

here is a patch : http://gist.github.com/351975

@twidi
Copy link
Contributor Author

twidi commented Apr 1, 2010

done in 52e3827

Kakadus pushed a commit to Kakadus/redis-py that referenced this issue Jan 10, 2025
Signed-off-by: Jay Miller <[email protected]>

### Pull Request check-list

_Please make sure to review and check all of these items:_

- [x] Do tests and lints pass with this change?
- [x] Do the CI tests pass with this change (enable it first in your
forked repo and wait for the github action build to finish)?
- [x] Is the new or changed code fully tested?
- [ ] Is a documentation update included (if this change modifies
existing APIs, or introduces new ones)?
- [ ] Is there an example added to the examples folder (if applicable)?
- [ ] Was the change added to CHANGES file?

_NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open._

### Description of change

PR that fixes commits from redis#34. 

Creates parity in testing on the sync/async tests of the connection pool
by skipping the ssl tests if ssl is not installed on the async tests.

Resolves redis#26

---------

Signed-off-by: Jay Miller <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>
Co-authored-by: Salvatore Mesoraca <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant