Feature request: Timeout connection if takes too long by adding optional timeout parameter

[shugyoku]

def connect(self, redis_instance):
...
    sock.setsockopt(socket.SOL_TCP, socket.TCP_NODELAY, 1)
+   sock.settimeout(self.timeout)
    self._sock = sock
    self._fp = sock.makefile('r')
    redis_instance._setup_connection()

[andymccurdy]

What operations are you running that take too long? Just curious, I have a pretty large Redis DB and all commands that I run on it return fairly instantly.

[shugyoku]

When the DB is in VM mode and/or is currently in the process of a synchronous save, operations can take several minutes for a large DB. The Redis client will actually wait until this operation completes without timing out. The timeout option is usually available in most clients to upper bound a single attempt. What I do is have 2 clients:

r = redis.Redis()
r_timeout = redis.Redis(timeout=1)

And use r_timeout where I need a time bound operation.

(In my use case, I fallback to a different DB if the connection times out).

Thank you.

[andymccurdy]

Committed and pushed in 97ed01d

[shugyoku]

Awesome, that's fast! Thanks.