change min_max parameter

Author: dvora-h

redis/commands/core.py

@@ -3260,7 +3260,8 @@ def zmpop(
         self,
         num_keys: int,
         keys: List[str],
-        min_max: str,
+        min: Optional[bool] = False,
+        max: Optional[bool] = False,
         count: Optional[int] = 1,
     ) -> list:
         """
@@ -3269,7 +3270,13 @@ def zmpop(
 
         For more information check https://redis.io/commands/zmpop
         """
-        args = [num_keys] + keys + [min_max]
+        args = [num_keys] + keys
+        if (min and max) or (not min and not max):
+            raise DataError
+        elif min:
+            args.append("MIN")
+        else:
+            args.append("MAX")
         if count != 1:
             args.extend(["COUNT", count])
 

tests/test_commands.py

@@ -2063,11 +2063,11 @@ def test_bzpopmin(self, r):
     def test_zmpop(self, unstable_r):
         unstable_r.zadd("a", {"a1": 1, "a2": 2, "a3": 3})
         res = [b"a", [[b"a1", b"1"], [b"a2", b"2"]]]
-        assert unstable_r.zmpop("2", ["b", "a"], "MIN", count=2) == res
-        with pytest.raises(TypeError):
+        assert unstable_r.zmpop("2", ["b", "a"], min=True, count=2) == res
+        with pytest.raises(redis.DataError):
             unstable_r.zmpop("2", ["b", "a"], count=2)
         unstable_r.zadd("b", {"b1": 10, "ab": 9, "b3": 8})
-        assert unstable_r.zmpop("2", ["b", "a"], "MAX") == [b"b", [[b"b1", b"10"]]]
+        assert unstable_r.zmpop("2", ["b", "a"], max=True) == [b"b", [[b"b1", b"10"]]]
 
     def test_zrange(self, r):
         r.zadd("a", {"a1": 1, "a2": 2, "a3": 3})