Skip to content

Commit 13a2b96

Browse files
authored
Topologies (#319)
* create a unique filename for different topologies instead of always hardcoding to: oss-standalone * adding topology info to aggregate results as well
1 parent 30ba22f commit 13a2b96

File tree

1 file changed

+11
-3
lines changed
  • redis_benchmarks_specification/__runner__

1 file changed

+11
-3
lines changed

redis_benchmarks_specification/__runner__/runner.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1686,7 +1686,7 @@ def delete_temporary_files(
16861686
logging.info(
16871687
f"Connected to Redis using individual parameters: {host}:{port}"
16881688
)
1689-
setup_name = "oss-standalone"
1689+
setup_name = topology_spec_name
16901690
r.ping()
16911691

16921692
# Auto-detect server information if not explicitly provided
@@ -2440,7 +2440,7 @@ def delete_temporary_files(
24402440
start_time_str,
24412441
git_hash,
24422442
test_name,
2443-
setup_type,
2443+
setup_name,
24442444
)
24452445
logging.info(
24462446
"Will store benchmark json output to local file {}".format(
@@ -2872,6 +2872,7 @@ def delete_temporary_files(
28722872
test_name,
28732873
results_matrix,
28742874
redis_conns,
2875+
setup_name,
28752876
)
28762877
else:
28772878
# Single client - read from file as usual
@@ -2950,6 +2951,7 @@ def delete_temporary_files(
29502951
test_name,
29512952
results_matrix,
29522953
redis_conns,
2954+
setup_name,
29532955
)
29542956

29552957
dataset_load_duration_seconds = 0
@@ -3525,6 +3527,7 @@ def prepare_overall_total_test_results(
35253527
test_name,
35263528
overall_results_matrix,
35273529
redis_conns=None,
3530+
topology=None,
35283531
):
35293532
# check which metrics to extract
35303533
(
@@ -3560,8 +3563,13 @@ def get_overall_display_name(x):
35603563

35613564
return x[0] # Use original path
35623565

3566+
# Include topology in the test name if provided
3567+
test_name_with_topology = test_name
3568+
if topology:
3569+
test_name_with_topology = f"{topology}-{test_name}"
3570+
35633571
current_test_results_matrix = [
3564-
[test_name, get_overall_display_name(x), f"{x[3]:.3f}"]
3572+
[test_name_with_topology, get_overall_display_name(x), f"{x[3]:.3f}"]
35653573
for x in current_test_results_matrix
35663574
]
35673575
overall_results_matrix.extend(current_test_results_matrix)

0 commit comments

Comments
 (0)