Skip to content

Commit bbc3514

Browse files
committed
Re-create csc.util package
1 parent 158b941 commit bbc3514

File tree

7 files changed

+29
-17
lines changed

7 files changed

+29
-17
lines changed

src/main/java/redis/clients/jedis/csc/ClientSideCache.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212

1313
/**
1414
* The class to manage the client-side caching. User can provide any of implementation of this class to the client
15-
* object; e.g. {@link redis.clients.jedis.csc.CaffeineCSC CaffeineCSC} or
16-
* {@link redis.clients.jedis.csc.GuavaCSC GuavaCSC} or a custom implementation of their own.
15+
* object; e.g. {@link redis.clients.jedis.csc.util.CaffeineCSC CaffeineCSC} or
16+
* {@link redis.clients.jedis.csc.util.GuavaCSC GuavaCSC} or a custom implementation of their own.
1717
*/
1818
public abstract class ClientSideCache {
1919

src/main/java/redis/clients/jedis/csc/CaffeineCSC.java renamed to src/main/java/redis/clients/jedis/csc/util/CaffeineCSC.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,33 @@
1-
package redis.clients.jedis.csc;
1+
package redis.clients.jedis.csc.util;
22

33
import com.github.benmanes.caffeine.cache.Cache;
44
import com.github.benmanes.caffeine.cache.Caffeine;
55
import java.util.concurrent.TimeUnit;
66
import net.openhft.hashing.LongHashFunction;
7+
78
import redis.clients.jedis.CommandObject;
89
import redis.clients.jedis.args.Rawable;
10+
import redis.clients.jedis.csc.ClientSideCache;
11+
import redis.clients.jedis.csc.ClientSideCacheable;
12+
import redis.clients.jedis.csc.DefaultClientSideCacheable;
913

1014
public class CaffeineCSC extends ClientSideCache {
1115

1216
private static final LongHashFunction DEFAULT_HASH_FUNCTION = LongHashFunction.xx3();
1317

1418
private final Cache<Long, Object> cache;
15-
private final LongHashFunction function;
19+
private final LongHashFunction hashFunction;
1620

1721
public CaffeineCSC(Cache<Long, Object> caffeineCache, LongHashFunction hashFunction) {
1822
super();
1923
this.cache = caffeineCache;
20-
this.function = hashFunction;
24+
this.hashFunction = hashFunction;
2125
}
2226

2327
public CaffeineCSC(Cache<Long, Object> caffeineCache, LongHashFunction function, ClientSideCacheable cacheable) {
2428
super(cacheable);
2529
this.cache = caffeineCache;
26-
this.function = function;
30+
this.hashFunction = function;
2731
}
2832

2933
@Override
@@ -51,10 +55,10 @@ protected final long getHash(CommandObject command) {
5155
long[] nums = new long[command.getArguments().size() + 1];
5256
int idx = 0;
5357
for (Rawable raw : command.getArguments()) {
54-
nums[idx++] = function.hashBytes(raw.getRaw());
58+
nums[idx++] = hashFunction.hashBytes(raw.getRaw());
5559
}
56-
nums[idx] = function.hashInt(command.getBuilder().hashCode());
57-
return function.hashLongs(nums);
60+
nums[idx] = hashFunction.hashInt(command.getBuilder().hashCode());
61+
return hashFunction.hashLongs(nums);
5862
}
5963

6064
public static Builder builder() {

src/main/java/redis/clients/jedis/csc/GuavaCSC.java renamed to src/main/java/redis/clients/jedis/csc/util/GuavaCSC.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,22 @@
1-
package redis.clients.jedis.csc;
1+
package redis.clients.jedis.csc.util;
22

33
import com.google.common.cache.Cache;
44
import com.google.common.cache.CacheBuilder;
55
import com.google.common.hash.HashFunction;
66
import com.google.common.hash.Hasher;
77
import java.util.concurrent.TimeUnit;
8+
89
import redis.clients.jedis.CommandObject;
10+
import redis.clients.jedis.csc.ClientSideCache;
11+
import redis.clients.jedis.csc.ClientSideCacheable;
12+
import redis.clients.jedis.csc.DefaultClientSideCacheable;
913

1014
public class GuavaCSC extends ClientSideCache {
1115

1216
private static final HashFunction DEFAULT_HASH_FUNCTION = com.google.common.hash.Hashing.fingerprint2011();
1317

1418
private final Cache<Long, Object> cache;
15-
private final HashFunction function;
19+
private final HashFunction hashFunction;
1620

1721
public GuavaCSC(Cache<Long, Object> guavaCache) {
1822
this(guavaCache, DEFAULT_HASH_FUNCTION);
@@ -21,7 +25,7 @@ public GuavaCSC(Cache<Long, Object> guavaCache) {
2125
public GuavaCSC(Cache<Long, Object> guavaCache, HashFunction hashFunction) {
2226
super();
2327
this.cache = guavaCache;
24-
this.function = hashFunction;
28+
this.hashFunction = hashFunction;
2529
}
2630

2731
public GuavaCSC(Cache<Long, Object> guavaCache, ClientSideCacheable cacheable) {
@@ -31,7 +35,7 @@ public GuavaCSC(Cache<Long, Object> guavaCache, ClientSideCacheable cacheable) {
3135
public GuavaCSC(Cache<Long, Object> cache, HashFunction function, ClientSideCacheable cacheable) {
3236
super(cacheable);
3337
this.cache = cache;
34-
this.function = function;
38+
this.hashFunction = function;
3539
}
3640

3741
@Override
@@ -56,7 +60,7 @@ protected Object getValue(long hash) {
5660

5761
@Override
5862
protected final long getHash(CommandObject command) {
59-
Hasher hasher = function.newHasher();
63+
Hasher hasher = hashFunction.newHasher();
6064
command.getArguments().forEach(raw -> hasher.putBytes(raw.getRaw()));
6165
hasher.putInt(command.getBuilder().hashCode());
6266
return hasher.hash().asLong();

src/main/java/redis/clients/jedis/csc/StringWhiteListBlackListClientSideCacheable.java renamed to src/main/java/redis/clients/jedis/csc/util/StringWhiteListBlackListClientSideCacheable.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
package redis.clients.jedis.csc;
1+
package redis.clients.jedis.csc.util;
22

33
import java.util.Set;
44
import redis.clients.jedis.commands.ProtocolCommand;
5+
import redis.clients.jedis.csc.ClientSideCacheable;
56

67
public class StringWhiteListBlackListClientSideCacheable implements ClientSideCacheable {
78

src/main/java/redis/clients/jedis/util/JedisURIHelper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
import redis.clients.jedis.Protocol;
77
import redis.clients.jedis.RedisProtocol;
88

9-
import redis.clients.jedis.csc.GuavaCSC;
10-
import redis.clients.jedis.csc.CaffeineCSC;
119
import redis.clients.jedis.csc.ClientSideCache;
10+
import redis.clients.jedis.csc.util.GuavaCSC;
11+
import redis.clients.jedis.csc.util.CaffeineCSC;
1212

1313
public final class JedisURIHelper {
1414

src/test/java/redis/clients/jedis/csc/ClientSideCacheLibsTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
import redis.clients.jedis.Jedis;
2424
import redis.clients.jedis.JedisClientConfig;
2525
import redis.clients.jedis.JedisPooled;
26+
import redis.clients.jedis.csc.util.CaffeineCSC;
27+
import redis.clients.jedis.csc.util.GuavaCSC;
2628

2729
public class ClientSideCacheLibsTest {
2830

src/test/java/redis/clients/jedis/csc/WhiteListBlackListClientSideCacheTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import redis.clients.jedis.JedisClientConfig;
2222
import redis.clients.jedis.JedisPooled;
2323
import redis.clients.jedis.Protocol;
24+
import redis.clients.jedis.csc.util.StringWhiteListBlackListClientSideCacheable;
2425

2526
public class WhiteListBlackListClientSideCacheTest {
2627

0 commit comments

Comments
 (0)