wip(tests): run doctests for vector sets on redis 8 only

Author: ndyakov

.github/workflows/doctests.yaml

@@ -16,9 +16,11 @@ jobs:
 
     services:
       redis-stack:
-        image: redis/redis-stack-server:latest
-        options: >-
-          --health-cmd "redis-cli ping" --health-interval 10s --health-timeout 5s --health-retries 5
+        image: redislabs/client-libs-test:8.0.1-pre
+        env:
+          TLS_ENABLED: no
+          REDIS_CLUSTER: no
+          PORT: 6379
         ports:
           - 6379:6379
 
@@ -38,4 +40,4 @@ jobs:
 
       - name: Test doc examples
         working-directory: ./doctests
-        run: go test -v
+        run: make test

Makefile

@@ -8,7 +8,19 @@ docker.stop:
 
 test:
 	$(MAKE) docker.start
-	$(MAKE) test.ci
+	@if [ -z "$(REDIS_VERSION)" ]; then \
+		echo "REDIS_VERSION not set, running all tests"; \
+		$(MAKE) test.ci; \
+	else \
+		MAJOR_VERSION=$$(echo "$(REDIS_VERSION)" | cut -d. -f1); \
+		if [ "$$MAJOR_VERSION" -ge 8 ]; then \
+			echo "REDIS_VERSION $(REDIS_VERSION) >= 8, running all tests"; \
+			$(MAKE) test.ci; \
+		else \
+			echo "REDIS_VERSION $(REDIS_VERSION) < 8, skipping vector_sets tests"; \
+			$(MAKE) test.ci.skip-vectorsets; \
+		fi; \
+	fi
 	$(MAKE) docker.stop
 
 test.ci:
@@ -22,10 +34,22 @@ test.ci:
 	cd internal/customvet && go build .
 	go vet -vettool ./internal/customvet/customvet
 
+test.ci.skip-vectorsets:
+	set -e; for dir in $(GO_MOD_DIRS); do \
+	  echo "go test in $${dir} (skipping vector sets)"; \
+	  (cd "$${dir}" && \
+	    go mod tidy -compat=1.18 && \
+	    go vet && \
+	    go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race \
+	      -run '^(?!.*(?:VectorSet|vectorset|ExampleClient_vectorset)).*$$'); \
+	done
+	cd internal/customvet && go build .
+	go vet -vettool ./internal/customvet/customvet
+
 bench:
 	go test ./... -test.run=NONE -test.bench=. -test.benchmem
 
-.PHONY: all test bench fmt
+.PHONY: all test test.ci test.ci.skip-vectorsets bench fmt
 
 build:
 	go build .

doctests/Makefile

@@ -0,0 +1,16 @@
+test:
+	@if [ -z "$(REDIS_VERSION)" ]; then \
+		echo "REDIS_VERSION not set, running all tests"; \
+		go test -v ./...; \
+	else \
+		MAJOR_VERSION=$$(echo "$(REDIS_VERSION)" | cut -d. -f1); \
+		if [ "$$MAJOR_VERSION" -ge 8 ]; then \
+			echo "REDIS_VERSION $(REDIS_VERSION) >= 8, running all tests"; \
+			go test -v ./...; \
+		else \
+			echo "REDIS_VERSION $(REDIS_VERSION) < 8, skipping vector_sets tests"; \
+			go test -v ./... -run '^(?!.*(?:vectorset|ExampleClient_vectorset)).*$$'; \
+		fi; \
+	fi
+
+.PHONY: test

doctests/main_test.go

@@ -0,0 +1,16 @@
+package example_commands_test
+
+import (
+	"fmt"
+	"os"
+	"strconv"
+	"strings"
+)
+
+var RedisVersion float64
+
+func init() {
+	// read REDIS_VERSION from env
+	RedisVersion, _ = strconv.ParseFloat(strings.Trim(os.Getenv("REDIS_VERSION"), "\""), 64)
+	fmt.Printf("REDIS_VERSION: %.1f\n", RedisVersion)
+}

doctests/vec_set_test.go

@@ -13,6 +13,11 @@ import (
 // HIDE_END
 
 func ExampleClient_vectorset() {
+	// HIDE_START
+	if RedisVersion < 8.0 {
+		return
+	}
+	// HIDE_END
 	ctx := context.Background()
 
 	rdb := redis.NewClient(&redis.Options{
@@ -381,6 +386,11 @@ func ExampleClient_vectorset() {
 }
 
 func ExampleClient_vectorset_quantization() {
+	// HIDE_START
+	if RedisVersion < 8.0 {
+		return
+	}
+	// HIDE_END
 	ctx := context.Background()
 
 	rdb := redis.NewClient(&redis.Options{
@@ -474,6 +484,11 @@ func ExampleClient_vectorset_quantization() {
 }
 
 func ExampleClient_vectorset_dimension_reduction() {
+	// HIDE_START
+	if RedisVersion < 8.0 {
+		return
+	}
+	// HIDE_END
 	ctx := context.Background()
 
 	rdb := redis.NewClient(&redis.Options{