add flag to disable raising exceptions with pipelined #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippeboyd
changed the title
philippeboyd
force-pushed
the
feature/add-pipeline-raise_exception-flag
branch
from
0aa2d59 to
1aef7eb
Compare
philippeboyd
force-pushed
the
feature/add-pipeline-raise_exception-flag
branch
2 times, most recently
from
dd702ca to
af56b57
Compare
casperisfine
approved these changes
Apr 10, 2024
philippeboyd
force-pushed
the
feature/add-pipeline-raise_exception-flag
branch
from
af56b57 to
54f18fc
Compare
philippeboyd
commented
Apr 10, 2024
lib/redis_client.rb
Outdated
| @timeouts = nil | ||
| @raise_exception = raise_exception |
There was a problem hiding this comment.
@casperisfine should these also be renamed to exception. I feel like exception would be more suitable for an exception object itself and not a boolean flag such as raise_exception. What do you think?
philippeboyd
force-pushed
the
feature/add-pipeline-raise_exception-flag
branch
3 times, most recently
from
8e0d595 to
729faea
Compare
philippeboyd
force-pushed
the
feature/add-pipeline-raise_exception-flag
branch
from
729faea to
662d269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the
pipelinedmethod inlib/redis_client.rbto include an optionalexceptionparameter, which determines whether an exception should be raised when an error occurs during pipelining.This gives better flexibility for error management when we want to retry only failed commands.