Notifications: respect project.versioning_scheme for links
#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for now since the backend API is not returning this URLs due to readthedocs/readthedocs-ops#1323. However, we cannot fix that quickly. I'm re-implementing a small version of the resolver for this by generating the URL based on the `project.versioning_scheme` for now. We should come back to this once the API returns the URLs we need. Closes #243
humitos
force-pushed
the
humitos/notifications-link-fix
branch
from
bb36156 to
5af6764
Compare
stsewd
reviewed
Mar 5, 2024
agjohnson
reviewed
Mar 6, 2024
This was referenced Mar 11, 2024
…ifications-link-fix
|
I updated this PR to use the URLs returned from the backend. It requires: |
agjohnson
approved these changes
Mar 21, 2024
humitos
added a commit
that referenced
this pull request
Apr 11, 2024
Implements the changes in the API made in readthedocs/readthedocs.org#11205. We need to merge that PR and deploy addons together with the changes in this PR. In this PR there are mainly no changes in the logic. The most important thing to mention here is that we are standardizing the usage of the API response and pinning to `v1` now (we were using `v0-alpha`). This means: - we will be exposing the `v1` to users via the js custom event (see #64) - we are using standard/shared APIv3 serializers for resources for this `/addons/` endpoint - any breaking change we have to do in the future it will increase the API response version I'm not sure there are too much to review here, but I'd appreciate at least a quick look at these changes. I'm happy to answer some questions you may have here or on the underlying PR about the API response changes. ### Related: * Closes #132 * Unblocks #265 * Unblocks theme integration (our theme and CPython's one) * Requires readthedocs/readthedocs.org#11205 --------- Co-authored-by: Anthony <[email protected]>
…ifications-link-fix
|
The API backend changes were merged, this PR is unblocked now and needs a small updates to make the tests pass and other small bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for now since the backend API is not returning this URLs due to https://github.com/readthedocs/readthedocs-ops/issues/1323. However, we cannot fix that quickly.
I'm re-implementing a small version of the resolver for this by generating the URL based on the
project.versioning_schemefor now.We should come back to this once the API returns the URLs we need.
Closes #243