Skip to content

Notifications: don't show warning if the project has only one version #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsewd opened this issue Sep 27, 2023 · 1 comment · Fixed by #166
Closed

Notifications: don't show warning if the project has only one version #159

stsewd opened this issue Sep 27, 2023 · 1 comment · Fixed by #166
Assignees
@humitos
Labels
Bug A bug

Comments

@stsewd
Copy link
Member

stsewd commented Sep 27, 2023

A project can have only one active version (and still be marked as multi-version project), in that case, there is no other version that we need to redirect to.
@humitos humitos self-assigned this Oct 10, 2023
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Oct 10, 2023
@humitos
Copy link
Member

humitos commented Oct 10, 2023 •
edited
Loading

This is also related to #132 and readthedocs/readthedocs.org#10791

We should not show the notification is stable or latest are not enabled, also.

humitos added a commit that referenced this issue Oct 16, 2023
@humitos
Notification: show it for "stable" only if stable is enabled
9748570 
Closes #159
@humitos humitos moved this from Planned to Needs review in 📍Roadmap Oct 16, 2023
@humitos humitos mentioned this issue Oct 18, 2023
Merged
@humitos humitos added the Bug A bug label Oct 18, 2023
humitos added a commit that referenced this issue Oct 25, 2023
@humitos
Notification: show it for "stable" only if stable is enabled (#166)
7715d7a 
Closes #159
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
Bug A bug
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notification: show it for "stable" only if stable is enabled readthedocs/addons
2 participants
@humitos @stsewd