The Server should always have a request listener

Author: clue

README.md

@@ -88,6 +88,10 @@ $http->on('request', function (Request $request, Response $response) {
 
 See also [`Request`](#request) and [`Response`](#response) for more details.
 
+> Note that you SHOULD always listen for the `request` event.
+Failing to do so will result in the server parsing the incoming request,
+but never sending a response back to the client.
+
 ### Request
 
 The `Request` class is responsible for streaming the incoming request body

src/Server.php

@@ -28,6 +28,10 @@
  *
  * See also [`Request`](#request) and [`Response`](#response) for more details.
  *
+ * Note that you SHOULD always listen for the `request` event.
+ * Failing to do so will result in the server parsing the incoming request,
+ * but never sending a response back to the client.
+ *
  * @see Request
  * @see Response
  */
@@ -112,12 +116,6 @@ public function handleRequest(ConnectionInterface $conn, Request $request, $body
         $response = new Response($conn);
         $response->on('close', array($request, 'close'));
 
-        if (!$this->listeners('request')) {
-            $response->end();
-
-            return;
-        }
-
         $this->emit('request', array($request, $response));
 
         if ($bodyBuffer !== '') {

tests/ServerTest.php

@@ -202,6 +202,28 @@ function ($data) use (&$buffer) {
         $this->assertContains("\r\nX-Powered-By: React/alpha\r\n", $buffer);
     }
 
+    public function testServerWithNoRequestListenerDoesNotSendAnythingToConnection()
+    {
+        $server = new Server($this->socket);
+
+        $this->connection
+            ->expects($this->never())
+            ->method('write');
+
+        $this->connection
+            ->expects($this->never())
+            ->method('end');
+
+        $this->connection
+            ->expects($this->never())
+            ->method('close');
+
+        $this->socket->emit('connection', array($this->connection));
+
+        $data = $this->createGetRequest();
+        $this->connection->emit('data', array($data));
+    }
+
     public function testParserErrorEmitted()
     {
         $error = null;