Merge pull request #122 from clue-labs/no-listener

The Server should always have a `request` listener

Author: WyriHaximus

README.md

@@ -88,6 +88,10 @@ $http->on('request', function (Request $request, Response $response) {
 
 See also [`Request`](#request) and [`Response`](#response) for more details.
 
+> Note that you SHOULD always listen for the `request` event.
+Failing to do so will result in the server parsing the incoming request,
+but never sending a response back to the client.
+
 The `Server` supports both HTTP/1.1 and HTTP/1.0 request messages.
 If a client sends an invalid request message or uses an invalid HTTP protocol
 version, it will emit an `error` event, send an HTTP error response to the

src/Server.php

@@ -28,6 +28,10 @@
  *
  * See also [`Request`](#request) and [`Response`](#response) for more details.
  *
+ * > Note that you SHOULD always listen for the `request` event.
+ *   Failing to do so will result in the server parsing the incoming request,
+ *   but never sending a response back to the client.
+ *
  * The `Server` supports both HTTP/1.1 and HTTP/1.0 request messages.
  * If a client sends an invalid request message or uses an invalid HTTP protocol
  * version, it will emit an `error` event, send an HTTP error response to the
@@ -118,12 +122,6 @@ public function handleRequest(ConnectionInterface $conn, Request $request)
         $response = new Response($conn, $request->getProtocolVersion());
         $response->on('close', array($request, 'close'));
 
-        if (!$this->listeners('request')) {
-            $response->end();
-
-            return;
-        }
-
         // attach remote ip to the request as metadata
         $request->remoteAddress = trim(
             parse_url('tcp://' . $conn->getRemoteAddress(), PHP_URL_HOST),

tests/ServerTest.php

@@ -339,6 +339,28 @@ function ($data) use (&$buffer) {
         $this->assertContains("\r\n\r\nError 505: HTTP Version Not Supported", $buffer);
     }
 
+    public function testServerWithNoRequestListenerDoesNotSendAnythingToConnection()
+    {
+        $server = new Server($this->socket);
+
+        $this->connection
+            ->expects($this->never())
+            ->method('write');
+
+        $this->connection
+            ->expects($this->never())
+            ->method('end');
+
+        $this->connection
+            ->expects($this->never())
+            ->method('close');
+
+        $this->socket->emit('connection', array($this->connection));
+
+        $data = $this->createGetRequest();
+        $this->connection->emit('data', array($data));
+    }
+
     public function testParserErrorEmitted()
     {
         $error = null;