Deprecate Executor $timeout parameter and switch to TimeoutConnector

Author: clue

src/Query/Executor.php

@@ -18,11 +18,15 @@ class Executor implements ExecutorInterface
     private $timeout;
 
     /**
+     *
+     * Note that albeit supported, the $timeout parameter is deprecated!
+     * You should pass a `null` value here instead. If you need timeout handling,
+     * use the `TimeoutConnector` instead.
      *
      * @param LoopInterface $loop
      * @param Parser $parser
      * @param BinaryDumper $dumper
-     * @param float|null $timeout timeout for DNS query or NULL=no timeout
+     * @param null|float $timeout DEPRECATED: timeout for DNS query or NULL=no timeout
      */
     public function __construct(LoopInterface $loop, Parser $parser, BinaryDumper $dumper, $timeout = 5)
     {

src/Resolver/Factory.php

@@ -11,6 +11,7 @@
 use React\Dns\Protocol\BinaryDumper;
 use React\EventLoop\LoopInterface;
 use React\Dns\Query\RetryExecutor;
+use React\Dns\Query\TimeoutExecutor;
 
 class Factory
 {
@@ -36,7 +37,11 @@ public function createCached($nameserver, LoopInterface $loop, CacheInterface $c
 
     protected function createExecutor(LoopInterface $loop)
     {
-        return new Executor($loop, new Parser(), new BinaryDumper());
+        return new TimeoutExecutor(
+            new Executor($loop, new Parser(), new BinaryDumper(), null),
+            5.0,
+            $loop
+        );
     }
 
     protected function createRetryExecutor(LoopInterface $loop)