Add createFromConfig factory methods

Author: WyriHaximus

examples/01-one.php

@@ -7,11 +7,8 @@
 
 $loop = React\EventLoop\Factory::create();
 
-$config = Config::loadSystemConfigBlocking();
-$server = $config->nameservers ? reset($config->nameservers) : '8.8.8.8';
-
 $factory = new Factory();
-$resolver = $factory->create($server, $loop);
+$resolver = $factory->createFromConfig(Config::loadSystemConfigBlocking(), $loop, '8.8.8.8');
 
 $name = isset($argv[1]) ? $argv[1] : 'www.google.com';
 

examples/02-concurrent.php

@@ -7,11 +7,8 @@
 
 $loop = React\EventLoop\Factory::create();
 
-$config = Config::loadSystemConfigBlocking();
-$server = $config->nameservers ? reset($config->nameservers) : '8.8.8.8';
-
 $factory = new Factory();
-$resolver = $factory->create($server, $loop);
+$resolver = $factory->createFromConfig(Config::loadSystemConfigBlocking(), $loop, '8.8.8.8');
 
 $names = array_slice($argv, 1);
 if (!$names) {

examples/03-cached.php

@@ -7,11 +7,8 @@
 
 $loop = React\EventLoop\Factory::create();
 
-$config = Config::loadSystemConfigBlocking();
-$server = $config->nameservers ? reset($config->nameservers) : '8.8.8.8';
-
 $factory = new Factory();
-$resolver = $factory->createCached($server, $loop);
+$resolver = $factory->createCachedFromConfig(Config::loadSystemConfigBlocking(), $loop, '8.8.8.8');
 
 $name = isset($argv[1]) ? $argv[1] : 'www.google.com';
 

examples/11-all-ips.php

@@ -8,11 +8,8 @@
 
 $loop = React\EventLoop\Factory::create();
 
-$config = Config::loadSystemConfigBlocking();
-$server = $config->nameservers ? reset($config->nameservers) : '8.8.8.8';
-
 $factory = new Factory();
-$resolver = $factory->create($server, $loop);
+$resolver = $factory->createFromConfig(Config::loadSystemConfigBlocking(), $loop, '8.8.8.8');
 
 $name = isset($argv[1]) ? $argv[1] : 'www.google.com';
 

examples/12-all-types.php

@@ -10,11 +10,8 @@
 
 $loop = React\EventLoop\Factory::create();
 
-$config = Config::loadSystemConfigBlocking();
-$server = $config->nameservers ? reset($config->nameservers) : '8.8.8.8';
-
 $factory = new Factory();
-$resolver = $factory->create($server, $loop);
+$resolver = $factory->createFromConfig(Config::loadSystemConfigBlocking(), $loop, '8.8.8.8');
 
 $name = isset($argv[1]) ? $argv[1] : 'google.com';
 $type = constant('React\Dns\Model\Message::TYPE_' . (isset($argv[2]) ? $argv[2] : 'TXT'));

examples/13-reverse-dns.php

@@ -8,11 +8,8 @@
 
 $loop = React\EventLoop\Factory::create();
 
-$config = Config::loadSystemConfigBlocking();
-$server = $config->nameservers ? reset($config->nameservers) : '8.8.8.8';
-
 $factory = new Factory();
-$resolver = $factory->create($server, $loop);
+$resolver = $factory->createFromConfig(Config::loadSystemConfigBlocking(), $loop, '8.8.8.8');
 
 $ip = isset($argv[1]) ? $argv[1] : '8.8.8.8';
 

src/Resolver/Factory.php

@@ -4,6 +4,7 @@
 
 use React\Cache\ArrayCache;
 use React\Cache\CacheInterface;
+use React\Dns\Config\Config;
 use React\Dns\Config\HostsFile;
 use React\Dns\Query\CachingExecutor;
 use React\Dns\Query\CoopExecutor;
@@ -18,6 +19,29 @@
 
 final class Factory
 {
+    /**
+     * @param Config        $config
+     * @param LoopInterface $loop
+     * @param string        $fallbackNameserver
+     * @return \React\Dns\Resolver\ResolverInterface
+     */
+    public function createFromConfig(Config $config, LoopInterface $loop, $fallbackNameserver)
+    {
+        return self::create($config->nameservers ? reset($config->nameservers) : $fallbackNameserver, $loop);
+    }
+
+    /**
+     * @param Config          $config
+     * @param LoopInterface   $loop
+     * @param string          $fallbackNameserver
+     * @param ?CacheInterface $cache
+     * @return \React\Dns\Resolver\ResolverInterface
+     */
+    public function createCachedFromConfig(Config $config, LoopInterface $loop, $fallbackNameserver, CacheInterface $cache = null)
+    {
+        return self::createCached($config->nameservers ? reset($config->nameservers) : $fallbackNameserver, $loop, $cache);
+    }
+
     /**
      * @param string        $nameserver
      * @param LoopInterface $loop