Skip to content

Translate "Don't Call PropTypes Warning" #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 21, 2019
Merged

Translate "Don't Call PropTypes Warning" #143

merged 11 commits into from
Feb 21, 2019

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Feb 15, 2019

No description provided.

@lex111 lex111 requested a review from another-guy February 15, 2019 00:36
@tesseralis tesseralis mentioned this pull request Feb 15, 2019
88 tasks
@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 15, 2019
>
> `React.PropTypes` has moved into a different package since React v15.5. Please use [the `prop-types` library instead](https://www.npmjs.com/package/prop-types).
> С версии React 15.5 `React.PropTypes` были вынесены в отдельный пакет. Так что используйте [библиотеку `prop-types`](https://www.npmjs.com/package/prop-types).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> С версии React 15.5 `React.PropTypes` были вынесены в отдельный пакет. Так что используйте [библиотеку `prop-types`](https://www.npmjs.com/package/prop-types).
> С версии React 15.5 `React.PropTypes` были вынесены в отдельный пакет. Вместо этого используйте [библиотеку `prop-types`](https://www.npmjs.com/package/prop-types).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: обновить файл с проверкой пропсов (брал оттуда это примечание, нужно синхронизировать)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 если это уже исправлено, то можно мёржить. 🎉

@another-guy another-guy removed their assignment Feb 21, 2019
@another-guy another-guy removed the needs review A pull request ready to be reviewed label Feb 21, 2019
@lex111 lex111 merged commit f874e14 into master Feb 21, 2019
@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for ru-reactjs failed.

Built with commit 37fcbba

https://app.netlify.com/sites/ru-reactjs/deploys/5c6ee835617b1f0007846513

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for ru-reactjs failed.

Built with commit 9946683

https://app.netlify.com/sites/ru-reactjs/deploys/5c6ee83c16a791000831f0b9

@lex111 lex111 deleted the dont-call-proptypes branch February 28, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants