Skip to content

K5 Showcase is not a react project anymore #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2018
Merged

K5 Showcase is not a react project anymore #696

merged 2 commits into from
Mar 21, 2018

Conversation

arjunsk
Copy link
Contributor

@arjunsk arjunsk commented Mar 20, 2018 •
edited
Loading

React Developer Tools didn't recognize the site (K5 Showcase) as react.

@arjunsk
K5 Showcase is not a react project anymore
e7e7770 
React Developer Tools didn't recognize the site as react.
@reactjs-bot
Copy link

reactjs-bot commented Mar 20, 2018 •
edited
Loading

Deploy preview for reactjs ready!

Built with commit 54a21ee

https://deploy-preview-696--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@alexkrolick
Copy link
Collaborator

URL appears to have changed, but it's still React

@alexkrolick alexkrolick merged commit 2793656 into reactjs:master Mar 21, 2018
@arjunsk arjunsk deleted the patch-1 branch March 21, 2018 17:14
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
@x-cold @QC-L @KnowsCount
[Beta] docs(cn): translate learn/index into Chinese (reactjs#696)
6d6f34e 
Co-authored-by: sooia <[email protected]>
Co-authored-by: QiChang Li <[email protected]>
Co-authored-by: KnowsCount <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arjunsk @reactjs-bot @facebook-github-bot @alexkrolick