Skip to content

removed line as functions can have state now too #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2019
Merged

removed line as functions can have state now too #1783

merged 2 commits into from
Mar 25, 2019

Conversation

saranshkataria
Copy link
Member

Fixes #1767

@reactjs-bot
Copy link

reactjs-bot commented Mar 5, 2019 •
edited
Loading

Deploy preview for reactjs ready!

Built with commit 1f98de8

https://deploy-preview-1783--reactjs.netlify.com

alexkrolick
alexkrolick reviewed Mar 5, 2019
View reviewed changes
Copy link
Collaborator

@alexkrolick alexkrolick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do so, it must call this.setState().

This should probably be updated as well

@saranshkataria
Copy link
Member Author

@alexkrolick done

@saranshkataria saranshkataria merged commit e744030 into master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkrolick alexkrolick alexkrolick left review comments

@tesseralis tesseralis tesseralis approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saranshkataria @reactjs-bot @tesseralis @alexkrolick @kambleaa007 @facebook-github-bot