Skip to content

Add missing avatarSize in "Before you use context" to text and code #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

GasimGasimzada
Copy link
Contributor

Added missing avatarSize prop in context docs to match the given source code

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit a718c9b

https://deploy-preview-1737--reactjs.netlify.com

@bvaughn
Copy link
Contributor

bvaughn commented Feb 23, 2019

Thanks @GasimGasimzada. Going to need to sign the CLA before I can merge though.

@GasimGasimzada
Copy link
Contributor Author

I am waiting for a response from "CLA team" as I have already signed the CLA (when submitting a PR for create-react-app).

@bvaughn
Copy link
Contributor

bvaughn commented Feb 23, 2019

You could always sign it again. I thought it was automated.

Anyway. I'll check back once it's signed. I can't do anything in the meanwhile.

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bvaughn bvaughn merged commit 8e805d7 into reactjs:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants