Skip to content

Changed wording about UNSAFE_componentWillReceiveProps deprecation #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Dec 6, 2018

I tried to compress this a little bit. (It's still a lot of words to have in one of our yellow "notes".) I also removed the misleading deprecation bit.

@reactjs-bot
Copy link

reactjs-bot commented Dec 6, 2018

Deploy preview for reactjs ready!

Built with commit 9e8bfd6

https://deploy-preview-1468--reactjs.netlify.com

@gaearon
Copy link
Member

gaearon commented Dec 6, 2018

Maybe let's combine this with note at the bottom? And make that paragraph first?

Same for other methods.

screen shot 2018-12-06 at 5 51 12 pm

@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 6, 2018

Maybe let's combine this with note at the bottom? And make that first?

I don't mind moving the note near the bottom higher up, but I'm not sure "combining" them feels right. This is already a lot of text for what (I think) is intended to be a short format note.

Same for other methods.

Not sure what this means.

@gaearon
Copy link
Member

gaearon commented Dec 6, 2018

I mean that other methods have the same note at the bottom and it’s very easy to miss. But arguably that’s the most important one and the one people most confused over. So I propose that every unsafe method starts with that note.

@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 6, 2018

Oh, so~ move those notes higher for each lifecycle? Sure, I'm not opposed to that.

@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 6, 2018

Okay I moved those comment blocks higher up.

@bvaughn bvaughn merged commit 08b71d9 into reactjs:master Dec 7, 2018
@bvaughn bvaughn deleted the UNSAFE_componentWillReceiveProps-deprecation-wording branch December 7, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants