Add CircleCI config #131
Add CircleCI config #131
Conversation
|
Deploy preview ready! Built with commit 086322a |
| - image: circleci/node:latest | ||
| steps: | ||
| - checkout | ||
| - restore_cache: |
There was a problem hiding this comment.
Do we need a step to explicitly install Yarn if it's not already installed? The React repo's circle.yml file has this:
pre:
# This is equivalent to $TRAVIS_COMMIT_RANGE
- echo $CIRCLE_COMPARE_URL | cut -d/ -f7
# install yarn if it's not already installed
- |
if [[ ! -e ~/.yarn/bin/yarn || $(yarn --version) != "${YARN_VERSION}" ]]; then
curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version $YARN_VERSION
fi
Maybe this isn't necessary with the 2.0 API. The 1.0 API docs have a section about how to enable Yarn which the 2.0 docs don't have. Maybe it just works out of the box now? 😁 Let's try and see!
There was a problem hiding this comment.
Pretty sure it’s already installed on v2
There was a problem hiding this comment.
Yeah, seems like that's the case.
| - checkout | ||
| - restore_cache: | ||
| keys: | ||
| - dependencies-{{ checksum "package.json" }} |
There was a problem hiding this comment.
I wonder if we should checksum "yarn.lock" instead? Seems like that may be better?
|
Looks good so far 👍 The first build commit (c4aaa15) failed: https://circleci.com/gh/reactjs/reactjs.org/1 This was because a Prettier issue had slipped in. I fixed it (42372b2) and the second build seems happy: https://circleci.com/gh/reactjs/reactjs.org/2 😄 |
…js#131) * translate navbar * Update content/docs/nav.yml Co-Authored-By: WeslleyNasRocha <[email protected]> * Apply suggestions from code review Co-Authored-By: WeslleyNasRocha <[email protected]>
This intends to fix the third and final item for #67.
Basically just runs the
ci-checkscript upon every build, as well as caching the project dependencies 🤗.