Skip to content

Hyperlink DRY #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Hyperlink DRY #129

merged 1 commit into from
Oct 11, 2017

Conversation

fatosmorina
Copy link
Contributor

I saw that Single responsibility principle from SOLID was hyperlinked, but DRY was not. This PR adds a hyperlink to DRY, to make things consistent throughout the documentation.

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 728b6f8

https://deploy-preview-129--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 😄 Thanks

@bvaughn bvaughn merged commit 2883359 into reactjs:master Oct 11, 2017
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
* Traduzir "Estado de componente" no FAQ

* Apply fixes from code review

Co-Authored-By: vhfmag <[email protected]>

* Add missing article, try new sentence structure

* Fix event handler translation to match convention

* Apply suggestions from code review

Co-Authored-By: vhfmag <[email protected]>

* Fix title

Co-Authored-By: vhfmag <[email protected]>
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
Integrating with other libraries
<!--

Thank you for the PR! Contributors like you keep React awesome!

Please see the Contribution Guide for guidelines:

https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md

If your PR references an existing issue, please add the issue number below

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants