-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Gracefully recover when ad block prevents Babel from loading #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Eh, maybe we could improve the error message slightly to mention ad blockers if we detect no Babel. I'll re-open and re-purpose for that. |
I can reproduce this, perhaps I can send a PR improving the message. |
Great! This issue is all yours! 😄 I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim. Cheers! |
Make the callback example more similar to the new API
* Translation of the "Handling Events" page
I've seen reports that certain ad blockers (eg Fair AdBlocker 1.404) prevent Babel from loading which causes a script error and results in the following:

We could detect this case (eg no Babel) and show an error message about ad blockers specifically, letting users know to whitelist reactjs.org if they want the live code examples to work.
Note that this issue is related to issue #2 and may be impacted by its implementation.
The text was updated successfully, but these errors were encountered: