chore: use React v18 as the default target for development #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
approved these changes
Mar 30, 2022
package.json
Outdated
| @@ -80,7 +80,7 @@ | |||
| "@semantic-release/npm": "^7.0.5", | |||
| "@storybook/addon-actions": "^6.3.4", | |||
| "@storybook/react": "^6.3.4", | |||
| "@testing-library/react": "^12.1.4", | |||
| "@testing-library/react": "^13.0.0-alpha.6", | |||
There was a problem hiding this comment.
Just released alpha.7 so it would be nice to use this repo as a canary ;)
There was a problem hiding this comment.
Thank you! I've addressed this at 62a44b0
|
🎉 This PR is included in version 4.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React v18 has been released 🎉
https://reactjs.org/blog/2022/03/29/react-v18.html
So I've change the default target version of React to v18. But we still test with v16 and v17 on CI, so this won't be a breaking change.
To support React v18, I've updated
@testing-library/reactand downgrade@testing-library/reactfor v16 and v17 on CI.