Skip to content
This repository was archived by the owner on Oct 26, 2018. It is now read-only.

Increase test coverage #43

Merged
merged 4 commits into from
Nov 25, 2015
Merged

Conversation

ellbee
Copy link
Member

@ellbee ellbee commented Nov 24, 2015

Add test coverage and some new tests to get up to near 100%

Statements : 100% ( 34/34 )
Branches : 95% ( 19/20 )
Functions : 100% ( 9/9 )
Lines : 100% ( 27/27 )

@ellbee ellbee force-pushed the increase_test_coverage branch from 5162e36 to 8b18a09 Compare November 25, 2015 09:34
@ellbee ellbee force-pushed the increase_test_coverage branch from 8b18a09 to 0b5bbae Compare November 25, 2015 09:37
@jlongster
Copy link
Member

Sweet! Thanks! I was hoping to get help with tests once I landed some basic ones.

Do you have any idea how we can test using diffing histories with this? I'd like to test HashHistory with this but I need a browser to do that.

jlongster added a commit that referenced this pull request Nov 25, 2015
@jlongster jlongster merged commit 40c57bb into reactjs:master Nov 25, 2015
@ellbee
Copy link
Member Author

ellbee commented Nov 25, 2015

Maybe we could follow the lead of react-router and history and set up a karma config for tests that need a browser? I could take a look at this if you'd like.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants