Update readme to refer to shakapacker #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangarha
changed the title
|
@alkesh26 @ahangarha Looks good. Should I merge? |
justin808
approved these changes
Nov 18, 2022
|
@justin808 If #1216 gets merged, I need to update this README file since Please check that PR. If rejected, this one can get merged. |
Replaced the installation guide to use Shakapacker instead of Webpacker. Also updated Typescript support based on the guideline in Shakapacker project.
Since modifying `source_entry_path` in `webpacker.yml` is automated now, we don't need to ask the users to do it manually.
ahangarha
force-pushed
the
update-readme-to-refer-to-shakapacker
branch
from
22a10d2 to
30614f3
Compare
ahangarha
changed the title
justin808
approved these changes
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated following files to refer to Shakapacker instead of Webpacker:
Note: #1216 automates replacing
/withpacksinwebpacker.yml. If that PR gets merged, this PR needs a minor update.Closes #1211