-
Notifications
You must be signed in to change notification settings - Fork 530
Pressing tab doesn't do anything #182
Comments
That's exactly what I did in #186. However it's nearly a year old. I'm not going to spend time rebasing it if it's never going to be merged. I'm just using my own fork of the component instead. |
@Daniel15 Yup, I noticed your PR just after posting my hasty initial reply and felt silly for missing it. I think I will need to go down a similar route; do you mind if I replicate some of the changes you made in my own fork, but with some changes to support React 16? (I tried using it locally and got errors related to React.PropTypes being deprecated now) |
Sure, go ahead. You can likely fork my fork, and then do the updates there 😄 |
@DanBuild @stern-shawn I'm not sure which of your |
@mellis481 My PR was developed against 1.8.1 and has been being used in production by my product since April with
|
I was able to write some code that gets select on tab working against the master branch. First, I have a component state object that stores the current Next I added a private variable to my wrapper component:
This is set by adding the following to the
Then I add a
My
Basically what this code will do is when Tab is pressed, it will find the item you highlighted and update the state |
When the dropdown is open, pressing tab just closes it without doing anything. With most other autocompletion components I've used, tab selects the currently active option, then moves to the next input field in the form.
Examples where pressing tab behaves this way:
The text was updated successfully, but these errors were encountered: