Skip to content

Add function and class component #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2019
Merged

Add function and class component #87

merged 2 commits into from
Feb 12, 2019

Conversation

klzns
Copy link
Contributor

@klzns klzns commented Feb 11, 2019

Following the changes made by the React team: reactjs/react.dev#863.

@klzns klzns changed the title Add function component Add function and class component Feb 11, 2019
@klzns klzns mentioned this pull request Feb 11, 2019
Merged
@fjoshuajr fjoshuajr added 📖 glossary | style-guide Definitions about terms in glossary and style-guide needs review A pull request ready to be reviewed labels Feb 11, 2019
glaucia86
glaucia86 approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klzns

LGTM 👍

@glaucia86 glaucia86 added the needs +1 Needs another approval before merging label Feb 12, 2019
fjoshuajr
fjoshuajr approved these changes Feb 12, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@fjoshuajr fjoshuajr removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Feb 12, 2019
@fjoshuajr fjoshuajr merged commit 4901d6f into reactjs:master Feb 12, 2019
@klzns klzns deleted the add-function-component branch February 12, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

Assignees
No one assigned
Labels
📖 glossary | style-guide Definitions about terms in glossary and style-guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klzns @glaucia86 @fjoshuajr