Skip to content

Translation mixins considered harmful #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Jun 26, 2020
Merged

Translation mixins considered harmful #425

merged 57 commits into from
Jun 26, 2020

Conversation

DanielObara
Copy link
Contributor

@DanielObara DanielObara commented Jun 11, 2020 •
edited by jhonmike
Loading

close #272

@netlify
Copy link

netlify bot commented Jun 11, 2020 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 778aa75

https://deploy-preview-425--pt-br-reactjs.netlify.app

@jhonmike jhonmike mentioned this pull request Jun 11, 2020
Closed
45 tasks
@jhonmike jhonmike added blog Blog post translation work in progress Author opened the pull-request but it's still being worked on 🌐 translated Translation is completed for this page and removed 🌐 translated Translation is completed for this page labels Jun 11, 2020
@DanielObara DanielObara changed the title WIP translation mixins considered harmful Translation mixins considered harmful Jun 13, 2020
@DanielObara
Copy link
Contributor Author

I believe the translation has been completed. Please review and tell me if something needs better translation.

@jhonmike jhonmike added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Jun 13, 2020
@jhonmike
Copy link
Member

@DanielObara consegue atualizar sua branch com a master, pois o build esta falhando.

@DanielObara
Copy link
Contributor Author

@jhonmike eu atualizei a master e fiz o merge com essa branch. Eu preciso criar outra branch a partir dessa master atualizada e abrir um outro pr ou consigo fazer nessa mesma branch atual?

jhonmike
jhonmike reviewed Jun 17, 2020
View reviewed changes
jussarasoares
jussarasoares reviewed Jun 23, 2020
View reviewed changes
@jhonmike jhonmike added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Jun 23, 2020
@jhonmike jhonmike added the needs +1 Needs another approval before merging label Jun 24, 2020
jussarasoares
jussarasoares previously approved these changes Jun 24, 2020
View reviewed changes
jhonmike
jhonmike reviewed Jun 25, 2020
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parabéns pela tradução, apenas encontrei alguns pequenos ajustes!

DanielObara and others added 19 commits June 26, 2020 16:56
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
d848415 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
3aadf79 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
cb85465 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
3df0cb2 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
8f903ea 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
5aa80a4 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
d5dcfd8 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
22f099d 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
0707702 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
b91a676 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
4c05f8b 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
a5d2083 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
b70fc56 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
ca57b89 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
08f8cbc 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
a9858d4 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
d5e5dc8 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
5b55c68 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara @jhonmike
Update content/blog/2016-07-13-mixins-considered-harmful.md
71a0601 
Co-authored-by: Jhon Mike <[email protected]>
@DanielObara
Copy link
Contributor Author

Uff acho que agora foi tudo né? hahaha

@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Jun 26, 2020
@jhonmike jhonmike merged commit 2a4f4b0 into reactjs:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonmike jhonmike jhonmike approved these changes

@jussarasoares jussarasoares jussarasoares left review comments

Assignees
No one assigned
Labels
blog Blog post translation 🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate 2016-07-13-mixins-considered-harmful.md
3 participants
@DanielObara @jhonmike @jussarasoares