Skip to content

Translated Community/Courses; #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2019
Merged

Translated Community/Courses; #158

merged 2 commits into from
Mar 11, 2019

Conversation

Duduzera1997
Copy link
Contributor

@Duduzera1997 Duduzera1997 commented Mar 11, 2019 •
edited
Loading

Community/Courses traduzida.
Gostaria de também ver se existe a possibilidade de incluir o ReactJS Ninja na parte de Cursos Pagos, pois muitos o consideram como o melhor curso de ReactJS em PT/BR.

@netlify
Copy link

netlify bot commented Mar 11, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 82934df

https://deploy-preview-158--pt-br-reactjs.netlify.com

jhonmike
jhonmike previously approved these changes Mar 11, 2019
View reviewed changes
@jhonmike
Copy link
Member

jhonmike commented Mar 11, 2019 •
edited
Loading

@Duduzera1997 eu não sei como podemos proceder com esse processo de adicionar um novo curso apenas na versão pt-br, até onde sei deveríamos ser fieis a versão original, mas nesse caso entendo que é algo específico em português.

Alguma dica pessoal? @reactjs/reactjs-org-portuguese-brazil-translation

@jhonmike jhonmike added the needs +1 Needs another approval before merging label Mar 11, 2019
eduardomoroni
eduardomoroni previously approved these changes Mar 11, 2019
View reviewed changes
@eduardomoroni
Copy link
Member

Eu acho que seria maneiro.

@jhonmike jhonmike added needs author response Changes requested needing author's input question Further information is requested and removed needs +1 Needs another approval before merging needs author response Changes requested needing author's input labels Mar 11, 2019
@Duduzera1997
Copy link
Contributor Author

Fico no aguardo de vocês, sendo autorizado realizo a inclusão do curso e dou commit.

@jhonmike
Copy link
Member

Cara manda ver, se caso der um conflito quando alguém atualizar a versão original, o bot vai tratar e abrir um PR para a gente corrigir o conflito. e dai só sucesso!

@Duduzera1997 Duduzera1997 dismissed stale reviews from eduardomoroni and jhonmike via 82934df March 11, 2019 17:26
@jhonmike jhonmike added the 🌐 translated Translation is completed for this page label Mar 11, 2019
@Duduzera1997
Copy link
Contributor Author

Tranquilo, dei commit na inclusão!

@eduardomoroni
Copy link
Member

Mandou bem @Duduzera1997, eu acho que isso é uma boa maneira de incluir pessoas que não sabem bem on ingles.

@eduardomoroni
Copy link
Member

@jhonmike, Mergear?

@jhonmike jhonmike merged commit 48c3324 into reactjs:master Mar 11, 2019
@tesseralis tesseralis mentioned this pull request Mar 11, 2019
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardomoroni eduardomoroni eduardomoroni approved these changes

@jhonmike jhonmike jhonmike approved these changes

Assignees
No one assigned
Labels
question Further information is requested 🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Duduzera1997 @jhonmike @eduardomoroni