Skip to content

Feat/hooks faq translation #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Mar 3, 2019
Merged

Feat/hooks faq translation #115

merged 25 commits into from
Mar 3, 2019

Conversation

frontendwizard
Copy link
Contributor

Please, note that this is pretty much unreviewed translation, so it's likely to have typos and some incorrect translations that diverge from the glossary. I'll review this tomorrow and fix all the issues that I can find. That said, if anyone wishes to review it too, here it is. I'll mark this as a draft PR till I review it.

@netlify
Copy link

netlify bot commented Feb 20, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 59e8bad

https://deploy-preview-115--pt-br-reactjs.netlify.com

@tibuurcio tibuurcio added needs review A pull request ready to be reviewed 💪 long page - more than 100 lines Long page labels Feb 20, 2019
Rahmon
Rahmon reviewed Feb 20, 2019
View reviewed changes
Luanf
Luanf reviewed Feb 21, 2019
View reviewed changes
@frontendwizard frontendwizard marked this pull request as ready for review February 21, 2019 12:35
@tesseralis tesseralis mentioned this pull request Feb 21, 2019
Closed
90 tasks
@halian-vilela halian-vilela mentioned this pull request Feb 21, 2019
Closed
8 tasks
Luanf
Luanf suggested changes Feb 21, 2019
View reviewed changes
@frontendwizard
Copy link
Contributor Author

Mais alguma coisa galera? Todos os erros apontados foram corrigidos.

jhonmike
jhonmike requested changes Feb 27, 2019
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Então comentei sobre o uso do Hook custom em um dos comentários acima, acho legal verificar todos no arquivo e tentar traduzir para Hooks customizados|personalizados.

Faltou revisar o finalzinho, assim que possível faço o resto da review

@halian-vilela halian-vilela added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 27, 2019
@halian-vilela halian-vilela self-assigned this Feb 27, 2019
@halian-vilela
Copy link
Collaborator

Legal galera, acho que as principais dúvidas estão resolvidas.

@thefrontendwizard pode fazer os últimos ajustes aí.

@Luanf e @jhonmike assim que ele fizer podem aprovar os reviews que a gente aprova a PR!

Valeu!

jhonmike
jhonmike requested changes Feb 27, 2019
View reviewed changes
Jhon Mike and others added 3 commits February 27, 2019 13:51
Fix typo
b93e88c 
Co-Authored-By: thefrontendwizard <[email protected]>
Remove duplicated line
c36e6ed 
Co-Authored-By: thefrontendwizard <[email protected]>
Fix grammar issues
565123a 
Co-Authored-By: thefrontendwizard <[email protected]>
Jhon Mike and others added 6 commits February 27, 2019 13:52
Change 'custom' to 'customizados'
50b3b23 
Co-Authored-By: thefrontendwizard <[email protected]>
Improve grammar
81b2487 
Co-Authored-By: thefrontendwizard <[email protected]>
Improve grammar
ee135e0 
Co-Authored-By: thefrontendwizard <[email protected]>
Update content/docs/hooks-faq.md
148c47c 
Co-Authored-By: thefrontendwizard <[email protected]>
Remove duplicated word
dc1dbc6 
Co-Authored-By: thefrontendwizard <[email protected]>
Fix grammar issues
39c66ac 
Co-Authored-By: thefrontendwizard <[email protected]>
@frontendwizard
Copy link
Contributor Author

Valeu pela review galera. Vou corrigir os últimos problemas relacionados a HOC aqui e já atualizo a PR.

@frontendwizard
Copy link
Contributor Author

There we go. Correções feitas.

Luanf
Luanf previously approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@Luanf Luanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Parece bão pra mim" 👍

jhonmike
jhonmike requested changes Feb 28, 2019
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ainda tem vários Hook custom, não vou comentar em todos, acho q um ctrl+f resolve ae para encontrar hehe

Change custom to customizados
d77c345 
Co-Authored-By: thefrontendwizard <[email protected]>
@frontendwizard frontendwizard dismissed stale reviews from Luanf via d77c345 February 28, 2019 14:21
@frontendwizard
Copy link
Contributor Author

Ok, agora os problemas com custom foram resolvidos. Mudei para customizado/customizados aonde era necessário.

jhonmike
jhonmike approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

glaucia86
glaucia86 approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefrontendwizard Parabéns! A sua contribuição foi aprovada!
Agradecemos e muito pela sua excelente contribuição!

LGTM 👍

@glaucia86 glaucia86 merged commit 515a4c0 into reactjs:master Mar 3, 2019
@glaucia86 glaucia86 added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input 💪 long page - more than 100 lines Long page labels Mar 3, 2019
@frontendwizard frontendwizard deleted the feat/hooks-faq-translation branch March 5, 2019 15:52
@tibuurcio tibuurcio mentioned this pull request Mar 7, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halian-vilela halian-vilela halian-vilela left review comments

@Rahmon Rahmon Rahmon left review comments

@glaucia86 glaucia86 glaucia86 approved these changes

@jhonmike jhonmike jhonmike approved these changes

@Luanf Luanf Luanf left review comments

Assignees

@halian-vilela halian-vilela

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@frontendwizard @halian-vilela @glaucia86 @jhonmike @Rahmon @Luanf @tibuurcio