Skip to content

Translate Components and Props page #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Mar 18, 2019

Conversation

arekmaz
Copy link
Contributor

@arekmaz arekmaz commented Mar 6, 2019

Translation of the Components and Props page

@arekmaz arekmaz changed the title Translate Components and Props page Translate Components and Props page #wip Mar 6, 2019
@netlify
Copy link

netlify bot commented Mar 6, 2019

Deploy preview for pl-reactjs ready!

Built with commit 163f195

https://deploy-preview-45--pl-reactjs.netlify.com

@arekmaz arekmaz marked this pull request as ready for review March 6, 2019 12:40
@arekmaz arekmaz changed the title Translate Components and Props page #wip Translate Components and Props page Mar 6, 2019
@jakubdrozdek jakubdrozdek added this to the Core Pages milestone Mar 6, 2019
@cvqprs cvqprs added the needs review A pull request ready to be reviewed label Mar 10, 2019
@jakubdrozdek jakubdrozdek added the 🚼 good first issue Good for newcomers label Mar 11, 2019
@jakubdrozdek jakubdrozdek added the needs +1 Needs another approval before merging label Mar 11, 2019

>**Note:** Always start component names with a capital letter.
>**Wskazówka:** Zawsze zaczynaj nazwy komponentów od dużej litery.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ewentualnie zmieniłbym na Uwaga, tak jak np. tu: https://github.com/reactjs/pl.reactjs.org/pull/40/files#diff-6024d880e5eef39cfbff54653ef34fb6R61
Wskazówka nie jest właściwie niepoprawna, ale bardziej pasuje do angielskiego Tip.

Suggested change
>**Wskazówka:** Zawsze zaczynaj nazwy komponentów od dużej litery.
>**Uwaga:** Zawsze zaczynaj nazwy komponentów od dużej litery.

Copy link

@jfrej jfrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one more comment, but in general all looks good!

@jakubdrozdek jakubdrozdek merged commit 9c6787e into reactjs:master Mar 18, 2019
@jakubdrozdek jakubdrozdek added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Mar 18, 2019
@cvqprs cvqprs removed the 🚼 good first issue Good for newcomers label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants