Skip to content

Translate Web Components #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 6, 2019
Merged

Conversation

hiddenest
Copy link
Contributor

@hiddenest hiddenest commented Feb 26, 2019

Progress

@netlify
Copy link

netlify bot commented Feb 26, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 2706662

https://deploy-preview-48--ko-reactjs-org.netlify.com

@hiddenest
Copy link
Contributor Author

@simsim0709 리뷰사항 반영하였습니다! 감사합니다 👍

@simsim0709 simsim0709 self-requested a review March 2, 2019 05:02
`주의:`에서 콜론을 제거 했습니다. 현재 [textlint 룰](https://github.com/reactjs/ko.reactjs.org/blob/master/textlint/rules/no-endline-colon.js) 에서 문장 맨끝에 콜론 사용을 안하는 걸로 되어 있어서요.
simsim0709
simsim0709 previously approved these changes Mar 2, 2019
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@simsim0709 simsim0709 requested review from taehwanno and gnujoow March 2, 2019 14:51
@hiddenest
Copy link
Contributor Author

hiddenest commented Mar 3, 2019

@taehwanno 리뷰해주신 내용 모두 반영하였습니다! 읽어주셔서 감사합니다 👍
@simsim0709 새로 푸시를 했더니 Approve가 해제되었습니다ㅠㅠ 다시 확인 부탁드려도 될까요?

taehwanno
taehwanno previously approved these changes Mar 3, 2019
gnujoow
gnujoow previously requested changes Mar 5, 2019
@simsim0709 simsim0709 dismissed gnujoow’s stale review March 6, 2019 04:11

수정 요청 사항 제가 반영 했습니다.

Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@taehwanno taehwanno merged commit f5f90c3 into reactjs:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants