Skip to content

Sync with reactjs.org @ 89941123 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Sync with reactjs.org @ 89941123 #143

merged 3 commits into from
Jun 19, 2019

Conversation

reactjs-translation-bot
Copy link
Contributor

@reactjs-translation-bot reactjs-translation-bot commented Jun 19, 2019

This PR was automatically generated.

Merge changes from reactjs.org at 8994112

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.

iqbal125 and others added 2 commits June 18, 2019 14:16
This link is pointing to a much older version of Jest. I have added a link to the current page for snapshot testing for the current version of jest.
@netlify
Copy link

netlify bot commented Jun 19, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit b07a42c

https://deploy-preview-143--ko-reactjs-org.netlify.com

hg-pyun
hg-pyun previously approved these changes Jun 19, 2019
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL 교체가 필요할것같네요.

Jest의 스냅샷 테스트 기능으로 JSON 트리의 복사본을 파일로 자동 저장하여 테스트 내에서 변경되지 않았는지 확인할 수 있습니다. [자세히 알아보기](https://facebook.github.io/jest/blog/2016/07/27/jest-14.html)
=======
You can use Jest's snapshot testing feature to automatically save a copy of the JSON tree to a file and check in your tests that it hasn't changed: [Learn more about it](https://jestjs.io/docs/en/snapshot-testing).
>>>>>>> 899411236d5b1520ab8b8e7fad7d48c681abc69b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be fixed.

@taehwanno taehwanno merged commit a42e231 into master Jun 19, 2019
@taehwanno taehwanno deleted the sync-89941123 branch June 19, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants