Spanish Translation Final Tasks!

[tesseralis]

¡Felicidades!

Y'all are amazing! 🎊It's been two weeks and you're translated the entire React documentation into Spanish! Give yourselves a big round of applause 👏

Now, there are couple more errands to do before we can finally deploy:

• Replace "reactjs.org" to "es.reactjs.org in the following places:
  • package.json Change from reactjs.org to es.reactjs.org #159
  • site-constants.js Change from reactjs.org to es.reactjs.org #159
  • gatsby-config.js Change from reactjs.org to es.reactjs.org #159
  • MarkdownPage (the link href in "Edit this page") Change from reactjs.org to es.reactjs.org #159
• Change html.js to have the attribute lang="es" Change from reactjs.org to es.reactjs.org #159
• Deploy the site, either locally or through Netlify/Heroku, and go over each section to:
  • Make sure there are no formatting errors (dangling markdown/html tags) or untranslated English
  • Make sure the sections and style are consistent.
• Change the Algolia API key

Again, amazing work, and I can't wait to introduce es.reactjs.org to the world!

[alejandronanez]

It’s happening!

[alejandronanez]

Thanks to @loconluis for #159!

[alejandronanez]

I'll review the whole site during the weekend (life happens)! 😸

[carburo]

The site is deployed on Netlify so it's easier for everyone to take a look and review it.

[devrchancay]

It looks great on Netlify but they need to review #155

[Darking360]

Greetings y'all 🚀 awesome! I'll take a look maybe tomorrow or Monday and see all 💪

[tesseralis]

Would you all be okay with the current netlify deployment becoming es.reactjs.org? If so, we can get @ericnakagawa or @bvaughn to point es.reactjs.org to it.

[tesseralis]

I looked over it and had a few thoughts:

The headings in the home page are styled strangely?

We should at least translate the nav bar:

And the page title:

[carburo]

@tesseralis There is a pending PR (#160) that should translate the navbar. I should have it reviewed and merged later tonight.

[tesseralis]

@carburo great!

Elementos DOM/DOM Elements is inconsistent: https://es-react-js.netlify.com/docs/dom-elements.html

[tesseralis]

PRs for:

• the home page title: Translate home page title #163
• the home page code sample headers: Fix weird headings in home page code examples #165

[tesseralis]

This is less important but we can also search for links to en.wikipedia.org or developer.mozilla.org and seeing if there are any English links that have a better Spanish version.

[tesseralis]

One more thing: the text in the Search bar is cut off

Maybe it's best to just shorten it to "Buscar"?

[alejandronanez]

Hey @tesseralis @carburo @Darking360 @dmoralesm!

I just did a quick run through the whole website and everything seems to be ok 🎉 .

I found some minor things that could be improved and opened the respective PRs #169 #170 #171 #172

[Darking360]

PR #170 merged! 🚀

I'll take a look into core 💪

[Darking360]

Hey guys 💪 I was looking into the translation so far, I opened this PR in order to add my feedback and some things that I observed so far, I'm on React.Component right now, but I wanted you to take a look into what's there so far to not double fix the same thing.

I've seen some accents left, un-translated parts, code in spanish, some links to english docs and internal links not working for bad naming, so I've been fixing those, I hope to finish by tomorrow at noon 🤔

CC: @alejandronanez @carburo @dmoralesm @tesseralis

[lex111]

I would also like to join in the congratulations to the Spanish translation team. ¡Un gran trabajo, todos! 👏

@tesseralis excuse me for writing here, but since these are final tasks, I’m wondering why there’sn’t a task to set up the search, as I understand it, need to change the Algolia API key?

[tesseralis]

@lex111 you're totally right! We uh... should fix that.

[lex111]

@tesseralis it would be nice to have instructions on how to do this 👍

[tesseralis]

@lex111 I... have absolutely no idea.

Maybe @gaearon @ericnakagawa @bvaughn could help?

[tesseralis]

Seems like the site uses Algolia docsearch, which is invitation only. So we can probably do a few things:

• Have one of the maintainers apply for it pointing to es.reactjs.org. I have no idea if they’re quick at responding to requests, and it doesn’t seem like a good long term strategy for our 30+ languages
• disable the search for now (there should be a var in the search component) so people don’t see confusing English results
• think about switching search providers? Is that something possible? There are a few alternatives on the gatsby site.

[tesseralis]

Eh, I’m sure it’ll be fine with Algolia. The jp.vuejs.org has it working. I’ll just have to add it to the “starting out” guide

[escorponox]

I saw some minor issues in hooks-effect in the last review. I'll send a PR asap.

[tesseralis]

Guess what: https://es.reactjs.org

[bvaughn]

I'm trying to figure out how to force redirect HTTP -> HTTPS, but for now at least the master branch of this repo is being built by Netlify and I've setup the subdomain to point to the result.

[tesseralis]

IIRC you have to wait until the dns propagates and then they’ll either do it automatically or there’s a big green button you can push.

[tesseralis]

Just applied for Algolia docsearch. Should get a response in a few days. Until then, would we want to disable the search bar?

[bvaughn]

Yeah, thanks Nat! I was hoping that was the case based on this Stack Overflow post. Just waiting to see.

Until then, would we want to disable the search bar?

This might be good, so long as there's an issue to re-enable later.

[sergiodxa]

I saw the docs are already deployed, but it's not using HTTPS, Netlify should give a SSL cert for free with just a click in the admin panel.

[bvaughn]

I saw the docs are already deployed, but it's not using HTTPS

HTTPS is also available. It's just not forcefully redirecting. Supposedly this is something we can make Netlify do, I'm just not sure how yet.