Skip to content

Explicitly use "Pruébalo en CodePen" #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2019
Merged

Conversation

alejandronanez
Copy link
Member

When we used [](codepen:....) it was getting translated this to Try this on CodePen, making this explicit we ensure that we always get the Spanish version.

Relates to #158

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be better to change the default text in gatsby-config.js?

@Darking360
Copy link
Collaborator

Yes, I tried as @carburo mentioned and changing the line 62 of gatsby-config.js we can add the default text for these parts, like this:

defaultText: '<b>Pruébalo en CodePen</b>',

Maybe we should add it like that 🤔 @alejandronanez

@alejandronanez
Copy link
Member Author

@Darking360 @carburo I didn't know this could be done that way. I'll update my PR tonight or tomorrow if you guys want to jump in to ship this fast, feel free to do so! ✌️

@carburo carburo requested a review from Darking360 February 19, 2019 06:44
Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 🚀

@Darking360 Darking360 merged commit ccae80c into master Feb 19, 2019
@carburo carburo deleted the fix-default-codepen-links branch February 28, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants