Skip to content

Translated 2020-09-22-introducing-the-new-jsx-transform #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MigueMartelo
Copy link
Contributor

Translated 2020-09-22-introducing-the-new-jsx-transform.md #201

@netlify
Copy link

netlify bot commented Oct 6, 2020

Deploy preview for es-reactjs ready!

Built with commit beb210d

https://deploy-preview-396--es-reactjs.netlify.app

@carburo
Copy link
Member

carburo commented Oct 6, 2020

Hi, @MigueMartelo thanks for your contribution and for bringing to our attention the missing ids. However, as these are out of this PR scope, could you move those changes to a different PR? Also, the ids shouldn't be translated (as described here):
For example instead of:
## Usa HOCs para preocupaciones transversales {#usa-hocs-para-preocupaciones-transversales}
it should be:
## Usa HOCs para preocupaciones transversales {#use-hocs-for-cross-cutting-concerns}
as you can see here:
https://github.com/reactjs/reactjs.org/blob/master/content/docs/higher-order-components.md#use-hocs-for-cross-cutting-concerns-use-hocs-for-cross-cutting-concerns

I will try to review the rest of the PR tonight.

@MigueMartelo
Copy link
Contributor Author

Hi @carburo I don't know what happen, I only modified the .md for the post.

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MigueMartelo
No pude hacer una reseña profunda, pero si dejé algunos comentarios.
Además dejo aquí dos notas generales:

  • Creo que deberíamos usar una frase más idiomática como traducción para «under the hood», en lugar de «bajo el capó». Quizá sea una frase común en algunas variantes regionales del español, pero aún así sería preferible una frase que resulte natural para cualquier hispanohablante.
  • La traducción utiliza «usted» para la segunda persona del singular, pero como se indica en nuestra guía de traducción decidimos usar «tú» de forma consistente en toda la documentación.

@MigueMartelo MigueMartelo requested a review from carburo October 7, 2020 15:41
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MigueMartelo. This is the full review. I left some suggestions. Let me know in case you need additional context or disagree with the suggestion.

@vercel
Copy link

vercel bot commented Oct 13, 2020

@MigueMartelo is attempting to deploy a commit to the Facebook Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@MigueMartelo
Copy link
Contributor Author

Hi @carburo I don't know what happen with the las commit, can you help me? In this commits I only did the changes that you suggested me.
Thank you!

@MigueMartelo
Copy link
Contributor Author

Hi @carburo I don't know what happen with the las commit, can you help me? In this commits I only did the changes that you suggested me.
Thank you!

Sorry, the file had a conflict and I hadn't seen.

@carburo carburo merged commit 9745204 into reactjs:master Oct 21, 2020
@carburo carburo mentioned this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants