-
Notifications
You must be signed in to change notification settings - Fork 298
Translated 2020-09-22-introducing-the-new-jsx-transform #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated 2020-09-22-introducing-the-new-jsx-transform #396
Conversation
Deploy preview for es-reactjs ready! Built with commit beb210d |
Hi, @MigueMartelo thanks for your contribution and for bringing to our attention the missing ids. However, as these are out of this PR scope, could you move those changes to a different PR? Also, the ids shouldn't be translated (as described here): I will try to review the rest of the PR tonight. |
Hi @carburo I don't know what happen, I only modified the .md for the post. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MigueMartelo
No pude hacer una reseña profunda, pero si dejé algunos comentarios.
Además dejo aquí dos notas generales:
- Creo que deberíamos usar una frase más idiomática como traducción para «under the hood», en lugar de «bajo el capó». Quizá sea una frase común en algunas variantes regionales del español, pero aún así sería preferible una frase que resulte natural para cualquier hispanohablante.
- La traducción utiliza «usted» para la segunda persona del singular, pero como se indica en nuestra guía de traducción decidimos usar «tú» de forma consistente en toda la documentación.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MigueMartelo. This is the full review. I left some suggestions. Let me know in case you need additional context or disagree with the suggestion.
@MigueMartelo is attempting to deploy a commit to the Facebook Open Source Team on Vercel. A member of the Team first needs to authorize it. |
Hi @carburo I don't know what happen with the las commit, can you help me? In this commits I only did the changes that you suggested me. |
…rm-translate-to-spanish
Sorry, the file had a conflict and I hadn't seen. |
Translated
2020-09-22-introducing-the-new-jsx-transform.md
#201