Update tutorial.md #366
Merged
Update tutorial.md #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2017 12:46
Correct the highlighted line to match the change that is being discussed, namely that the CommentForm can call the callback when the user submits the form
Also highlight changed line where onSubmit event handler is added to form tag.
|
Could you please see if the ASP.NET 4 tutorial needs to be updated too? I
don't have my computer with me right now so it's difficult for me to check
:)
Sent from my phone.
…On Jan 7, 2017 9:47 PM, "Dan Padmore" ***@***.***> wrote:
Correct the highlighted line to match the change that is being discussed,
namely that the CommentForm can call the callback when the user submits the
form
------------------------------
You can view, comment on, or merge this pull request online at:
#366
Commit Summary
- Update tutorial.md
File Changes
- *M* site/jekyll/getting-started/tutorial.md
<https://github.com/reactjs/React.NET/pull/366/files#diff-0> (2)
Patch Links:
- https://github.com/reactjs/React.NET/pull/366.patch
- https://github.com/reactjs/React.NET/pull/366.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#366>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFnHZzXScVWo7XoYdwyfh7lhIa0lwuFks5rP3tggaJpZM4LdZqz>
.
|
|
You're right, the ASP.NET 4 tutorial needs to be updated in the same way. I'll attempt to include it in this pull request. |
|
You can include the change in the pull request if you switch to the right
branch on Github and then edit the file on Github :)
Sent from my phone.
…On Jan 7, 2017 10:08 PM, "Dan Padmore" ***@***.***> wrote:
You're right, the ASP.NET 4 tutorial
<https://reactjs.net/getting-started/tutorial_aspnet4.html> needs to be
updated in the same way.
I'll attempt to include it in this pull request.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#366 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFnHZ2KZvxjaNQaqpM-oewUiNFb8qdQks5rP4A8gaJpZM4LdZqz>
.
|
added 5 commits
January 7, 2017 13:12
Corrects the highlighted line in aspnet4 tutorial, to match the change that is being discussed, namely that the CommentForm can call the callback when the user submits the form
Also highlight changed line in aspnet4 tutorial, where onSubmit event handler is added to form tag.
Highlight complete block of added code lines.
Highlight complete block of added codes lines, in optimization part of tutorial.
Fix highlighted code lines in tutorial
|
There it is :) I didn't expect to do more than 1 change, so I had some more changes on a separate branch in my fork. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the highlighted line to match the change that is being discussed, namely that the CommentForm can call the callback when the user submits the form