+tck #236 example subscriber whitebox tested, and whitebox fixed #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
// cc @viktorklang |
| return signalNext(element); | ||
| } | ||
|
|
||
| public T signalNext(T element) throws InterruptedException { |
|
Aside from comments, 👍! |
ktoso
force-pushed
the
wip-whitebox-better-example
branch
from
a7878e2 to
ae354a8
Compare
|
Comments addressed 👍 |
|
@reactive-streams/contributors this is a documentation fix and bugfix for the TCK, will merge in 48h if no objections have been made |
|
Since this is all in the TCK I'm assuming it's fixing conformance with the spec, so I'm okay with it. |
ktoso
force-pushed
the
wip-whitebox-better-example
branch
from
ae354a8 to
99c0cad
Compare
viktorklang
added a commit
that referenced
this pull request
Mar 20, 2015
+tck #236 example subscriber whitebox tested, and whitebox fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds better example on using
SubscriberWhiteboxVerification- it now explains how you would use it with your impl, thanks @purplefox for pointing out the need for clarification here in #236!This PR also makes us use the whitebox to test the example subscriber. This found a bug in the new tests introduced during https://github.com/reactive-streams/reactive-streams-jvm/pull/209/files as it accidentally subscribed twice (whitebox's Stage is subscribing the
subto thepubduring creation). Fixed tests, and improved docs on these methods.Resolves #236