Skip to content

Update IDOM Sanic Requirement #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmorshea opened this issue Feb 18, 2022 Discussed in #674 · 0 comments · Fixed by #703
Closed

Update IDOM Sanic Requirement #678

rmorshea opened this issue Feb 18, 2022 Discussed in #674 · 0 comments · Fixed by #703

Comments

@rmorshea
Copy link
Collaborator

rmorshea commented Feb 18, 2022

It turns out that IDOM requires Sanic>19,<19.12. This is a slim range of versions because of this issue

Discussed in #674

Originally posted by gebrian0 February 16, 2022

>>> import idom
>>> from idom import component, html, run
>>> 
>>> 
>>> @component
... def App():
...     return html.h1("Hello, ddWorld!")
... 
>>> 
>>> run(App)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/idom/server/prefab.py", line 58, in run
    server = server_type(component, server_config, app)
  File "/usr/local/lib/python3.9/site-packages/idom/server/sanic.py", line 74, in PerClientStateServer
    return SanicServer(app)
  File "/usr/local/lib/python3.9/site-packages/idom/server/sanic.py", line 111, in __init__
    app.register_listener(self._server_did_start, "after_server_start")
AttributeError: 'Sanic' object has no attribute 'register_listener'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant