Skip to content

State mismatch during component update #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
Archmonger opened this issue Jan 29, 2022 · 3 comments · Fixed by #631
Closed
2 tasks

State mismatch during component update #629

Archmonger opened this issue Jan 29, 2022 · 3 comments · Fixed by #631
Labels
priority-0-critical Must be resolved and released immediately.
Milestone
1.0.0

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Jan 29, 2022 •
edited
Loading

Current Situation

Currently, updating any child component state can result in AssertionError: state mismatch during component update - key '61e47127-9d3f-4954-8235-4d99122134c1'!=4

This can be previewed within Conreq's app store branch.

Proposed Actions

Update layout.py to not cause this exception.

Work Items

  • Develop a fix for state mismatch
  • Release 0.35.5 to resolve this
@Archmonger Archmonger added the flag-triage Not prioritized. label Jan 29, 2022
@rmorshea rmorshea added priority-1-high Should be resolved ASAP. type: bug and removed flag-triage Not prioritized. labels Jan 29, 2022
@rmorshea rmorshea added this to the 1.0 milestone Jan 29, 2022
@rmorshea
Copy link
Collaborator

rmorshea commented Jan 29, 2022 •
edited
Loading

Ok, this isn't as bad as I thought. I'm pretty sure this assertion should just be removed entirely.

@Archmonger
Copy link
Contributor Author

Confirmed removing the assertion fixes the issue and causes no visible consequences.

Archmonger added a commit to Archmonger/reactpy that referenced this issue Jan 29, 2022
@Archmonger
fix reactive-python#629
b4f26ec
@Archmonger Archmonger mentioned this issue Jan 29, 2022
Merged
@Archmonger
Copy link
Contributor Author

Also, this issue is more of a P0 than a P1, since it fundamentally breaks IDOM

@rmorshea rmorshea added priority-0-critical Must be resolved and released immediately. and removed priority-1-high Should be resolved ASAP. labels Jan 29, 2022
@Archmonger Archmonger changed the title v0.35.4 regression: State mismatch during component update State mismatch during component update Jan 29, 2022
rmorshea pushed a commit that referenced this issue Jan 30, 2022
@Archmonger @rmorshea
fix #629
37a5be2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-0-critical Must be resolved and released immediately.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Fix state mismatch during component update Archmonger/reactpy
2 participants
@rmorshea @Archmonger