more ruff fixes

Author: rmorshea

.github/workflows/.nox-session.yml renamed to .github/workflows/.hatch-run.yml

@@ -1,17 +1,14 @@
-name: Nox Session
+name: hatch-run
 
 on:
   workflow_call:
     inputs:
       job-name:
         required: true
         type: string
-      nox-args:
+      hatch-run:
         required: true
         type: string
-      nox-session-args:
-        required: false
-        type: string
       runs-on-array:
         required: false
         type: string
@@ -29,7 +26,7 @@ on:
         required: false
 
 jobs:
-  nox-session:
+  hatch:
     name: ${{ format(inputs.job-name, matrix.python-version, matrix.runs-on) }}
     strategy:
       matrix:
@@ -55,4 +52,4 @@ jobs:
           NODE_AUTH_TOKEN: ${{ secrets.node-auth-token }}
           PYPI_USERNAME: ${{ secrets.pypi-username }}
           PYPI_PASSWORD: ${{ secrets.pypi-password }}
-        run: nox ${{ inputs.nox-args }} --stop-on-first-error -- ${{ inputs.nox-session-args }}
+        run: hatch run ${{ inputs.hatch-run }}

.github/workflows/test.yml

@@ -12,10 +12,10 @@ on:
 
 jobs:
   python-exhaustive:
-    uses: ./.github/workflows/.nox-session.yml
+    uses: ./.github/workflows/.hatch-run.yml
     with:
       job-name: "python-{0}"
-      nox-args: "-t check-python"
+      hatch-run: "-t check-python"
       nox-session-args: "--pytest --maxfail=3 --reruns 3"
   python-environments:
     uses: ./.github/workflows/.nox-session.yml
@@ -24,7 +24,7 @@ jobs:
       nox-args: "-s check-python-tests"
       nox-session-args: "--no-cov --pytest --maxfail=3 --reruns 3"
       runs-on-array: '["ubuntu-latest", "macos-latest", "windows-latest"]'
-      python-version-array: '["3.7", "3.8", "3.9", "3.10", "3.11"]'
+      python-version-array: '["3.9", "3.10", "3.11"]'
   docs:
     uses: ./.github/workflows/.nox-session.yml
     with:

docs/app.py

@@ -3,13 +3,11 @@
 
 from sanic import Sanic, response
 
+from docs.examples import get_normalized_example_name, load_examples
 from reactpy import component
 from reactpy.backend.sanic import Options, configure, use_request
 from reactpy.core.types import ComponentConstructor
 
-from .examples import get_normalized_example_name, load_examples
-
-
 HERE = Path(__file__).parent
 REACTPY_MODEL_SERVER_URL_PREFIX = "/_reactpy"
 
@@ -46,7 +44,7 @@ def make_app():
     app.static("/docs", str(HERE / "build"))
 
     @app.route("/")
-    async def forward_to_index(request):
+    async def forward_to_index(_):
         return response.redirect("/docs/index.html")
 
     configure(

docs/examples.py

@@ -1,14 +1,14 @@
 from __future__ import annotations
 
+from collections.abc import Iterator
 from io import StringIO
 from pathlib import Path
 from traceback import format_exc
-from typing import Callable, Iterator
+from typing import Callable
 
 import reactpy
 from reactpy.types import ComponentType
 
-
 HERE = Path(__file__)
 SOURCE_DIR = HERE.parent / "source"
 CONF_FILE = SOURCE_DIR / "conf.py"
@@ -148,7 +148,6 @@ def __init__(self, max_lines: int = 10):
 
     def set_callback(self, function: Callable[[str], None]) -> None:
         self._callback = function
-        return None
 
     def getvalue(self) -> str:
         return "".join(self._lines)

docs/source/_exts/async_doctest.py

@@ -6,7 +6,6 @@
 from sphinx.ext.doctest import DocTestBuilder
 from sphinx.ext.doctest import setup as doctest_setup
 
-
 test_template = """
 import asyncio as __test_template_asyncio
 
@@ -41,10 +40,8 @@ def test_runner(self) -> DocTestRunner:
     @test_runner.setter
     def test_runner(self, value: DocTestRunner) -> None:
         self._test_runner = TestRunnerWrapper(value)
-        return None
 
 
 def setup(app: Sphinx) -> None:
     doctest_setup(app)
     app.add_builder(AsyncDoctestBuilder, override=True)
-    return None

docs/source/_exts/autogen_api_docs.py

@@ -1,12 +1,11 @@
 from __future__ import annotations
 
 import sys
+from collections.abc import Collection, Iterator
 from pathlib import Path
-from typing import Collection, Iterator
 
 from sphinx.application import Sphinx
 
-
 HERE = Path(__file__).parent
 SRC = HERE.parent.parent.parent / "src"
 PYTHON_PACKAGE = SRC / "reactpy"
@@ -83,7 +82,9 @@ def get_module_name(path: Path) -> str:
 
 def get_section_symbol(path: Path) -> str:
     rel_path_parts = path.relative_to(PYTHON_PACKAGE).parts
-    assert len(rel_path_parts) < len(SECTION_SYMBOLS), "package structure is too deep"
+    if len(rel_path_parts) < len(SECTION_SYMBOLS):
+        msg = "package structure is too deep"
+        raise RuntimeError(msg)
     return SECTION_SYMBOLS[len(rel_path_parts)]
 
 

docs/source/_exts/build_custom_js.py

@@ -3,7 +3,6 @@
 
 from sphinx.application import Sphinx
 
-
 SOURCE_DIR = Path(__file__).parent.parent
 CUSTOM_JS_DIR = SOURCE_DIR / "_custom_js"
 

docs/source/_exts/custom_autosectionlabel.py

@@ -17,7 +17,6 @@
 from sphinx.util import logging
 from sphinx.util.nodes import clean_astext
 
-
 logger = logging.getLogger(__name__)
 
 

docs/source/_exts/reactpy_example.py

@@ -41,10 +41,8 @@ def run(self):
         ex_files = get_example_files_by_name(example_name)
         if not ex_files:
             src_file, line_num = self.get_source_info()
-            raise ValueError(
-                f"Missing example named {example_name!r} "
-                f"referenced by document {src_file}:{line_num}"
-            )
+            msg = f"Missing example named {example_name!r} referenced by document {src_file}:{line_num}"
+            raise ValueError(msg)
 
         labeled_tab_items: list[tuple[str, Any]] = []
         if len(ex_files) == 1:
@@ -114,7 +112,8 @@ def _literal_include(path: Path, linenos: bool):
             ".json": "json",
         }[path.suffix]
     except KeyError:
-        raise ValueError(f"Unknown extension type {path.suffix!r}")
+        msg = f"Unknown extension type {path.suffix!r}"
+        raise ValueError(msg) from None
 
     return _literal_include_template.format(
         name=str(path.relative_to(SOURCE_DIR)),

docs/source/_exts/reactpy_view.py

@@ -7,7 +7,6 @@
 
 from docs.examples import get_normalized_example_name
 
-
 _REACTPY_EXAMPLE_HOST = os.environ.get("REACTPY_DOC_EXAMPLE_SERVER_HOST", "")
 _REACTPY_STATIC_HOST = os.environ.get("REACTPY_DOC_STATIC_SERVER_HOST", "/docs").rstrip(
     "/"